New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673086 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 29 days ago
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

DevTOols: [Persistence] renaming file with a green checkmark allows to edit icon

Project Member Reported by lushnikov@chromium.org, Dec 10 2016

Issue description

What steps will reproduce the problem?
1. Rename file with a green checkmark on the right
2. Notica how checkmark is part of the editor

See screenshot for details.


 
Screen Shot 2016-12-09 at 7.48.39 PM.png
34.1 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d722a94d485ea9774e89678a1a8a74e56a42fc24

commit d722a94d485ea9774e89678a1a8a74e56a42fc24
Author: lushnikov <lushnikov@chromium.org>
Date: Tue Dec 13 03:10:45 2016

DevTools: [Persistence] green checkmark icons should not be editable

Today, navigator renders green checkmarks as a part of the title element.
This results in the editing field spanning over the icon as well.

This patch starts using treeelement.setTrailingIcons() method to
avoid this problem.

BUG= 673086 
R=dgozman

Review-Url: https://codereview.chromium.org/2568623002
Cr-Commit-Position: refs/heads/master@{#438016}

[modify] https://crrev.com/d722a94d485ea9774e89678a1a8a74e56a42fc24/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/d722a94d485ea9774e89678a1a8a74e56a42fc24/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator-expected.txt
[modify] https://crrev.com/d722a94d485ea9774e89678a1a8a74e56a42fc24/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
[modify] https://crrev.com/d722a94d485ea9774e89678a1a8a74e56a42fc24/third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29f641736f1abdbd30ba57cd036774d5801bb236

commit 29f641736f1abdbd30ba57cd036774d5801bb236
Author: lushnikov <lushnikov@chromium.org>
Date: Thu Dec 15 07:08:13 2016

DevTools: drastically simplify UISourceCode.checkContentUpdated

As a part of "Persistence" plan, the UISourceCode.checkContentUpdated
method should move away from UISourceCode.

This CL is a preparation for this. This patch kills a few clients of the
method, since they are not needed any more:
1. SourcesSearchScope shouldn't be forcing checkContentUpdated during search,
   it can simply request content
2. The UISourceCodeFrame shouldn't request content on focus - the iNotify
   reports changes while devtools are blurred.

BUG= 673086 
R=dgozman

Review-Url: https://codereview.chromium.org/2567283004
Cr-Commit-Position: refs/heads/master@{#438772}

[modify] https://crrev.com/29f641736f1abdbd30ba57cd036774d5801bb236/third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects-expected.txt
[delete] https://crrev.com/78f6bee5b544282274f8b962a7cca4bf98f2c621/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-checkContent-expected.txt
[delete] https://crrev.com/78f6bee5b544282274f8b962a7cca4bf98f2c621/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-checkContent.html
[modify] https://crrev.com/29f641736f1abdbd30ba57cd036774d5801bb236/third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js
[modify] https://crrev.com/29f641736f1abdbd30ba57cd036774d5801bb236/third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
[modify] https://crrev.com/29f641736f1abdbd30ba57cd036774d5801bb236/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js

Sign in to add a comment