New issue
Advanced search Search tips

Issue 673074 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Regression] DevTools: resources and network responses are editable

Project Member Reported by dgozman@chromium.org, Dec 10 2016

Issue description

They should not be. Regressed here: https://codereview.chromium.org/2450663004.
 
Labels: Needs-Feedback
dgozman@ Could you please provide any test steps and expected results if this can be verified from test team end.

Thanks,
Repro steps:
1. Load theverge.com
2. Open network panel, select a javascript resource (e.g. moatad.js).
3. Open "Response" tab at the right.
4. Click on the source, try to type something - should be readonly.
Labels: -Needs-Feedback
Labels: TE-Verified-57.0.2950.0 TE-Verified-M57
Tested the issue on windows 7 , Linux Ubuntu 14.04 and Mac 10.12.1 using chrome version 57.0.2950.0 and 57.0.2950.2(windows) with the steps from comment #3.the js file is read only. Not able to type anything in source of 
moatad.js.
Please find the attached screen cast for the same.

Adding TE-Verified labels.

Thanks,
673074.mp4
2.9 MB View Download
Labels: Merge-Request-56
Status: Fixed (was: Assigned)
Requesting merge to 56.

Comment 7 by dimu@chromium.org, Dec 14 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 14 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e13bd3af7eb1a99aaab3de4815424b5a9c9f9c7

commit 9e13bd3af7eb1a99aaab3de4815424b5a9c9f9c7
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Dec 14 20:06:31 2016

Merge to M56 "[DevTools] Make SourceFrame.setEditable work."
> [DevTools] Make SourceFrame.setEditable work.
>
> There were two bugs in readonly handling.
>
> BUG= 673074 
>
> Review-Url: https://codereview.chromium.org/2567633003
> Cr-Commit-Position: refs/heads/master@{#437772}
(cherry picked from commit 1baf153a336c4601f9092285ae0a8e4686fc4c88)
TBR=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2575153002 .
Cr-Commit-Position: refs/branch-heads/2924@{#496}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/9e13bd3af7eb1a99aaab3de4815424b5a9c9f9c7/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
[modify] https://crrev.com/9e13bd3af7eb1a99aaab3de4815424b5a9c9f9c7/third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js

Cc: kkaluri@chromium.org
Labels: TE-Verified-M56 TE-Verified-56.0.2924.51
Verified this issue on Windows-10, Mac OS 10.12.2 and Ubuntu 14.04 using chrome latest M56 #56.0.2924.51.0 by following steps mentioned in the comment #3.

Observed that the js file is read only. Not able to type anything in source of moatad.js
Please find the attached screen-cast for the same.

Adding TE-Verified labels.

Thanks,
Issue 673074.mp4
1.9 MB View Download

Sign in to add a comment