New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673052 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Mac
Pri: 3
Type: Bug

Blocking:
issue 665150



Sign in to add a comment

Add |cornerPoints| to DetectedBarcode.idl

Project Member Reported by mcasas@chromium.org, Dec 10 2016

Issue description

DetectedBarcode.idl [1] has recently got added another field |cornerPoints| [2] that should be implemented and wired.

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.idl
[2] https://wicg.github.io/shape-detection-api/#barcode-detection-api
 

Comment 1 by mcasas@chromium.org, Dec 10 2016

Blocking: 665150
Cc: paulkinlan@chromium.org mcasas@chromium.org
Components: Blink>ImageCapture
Labels: ShapeDetection OS-Android
Owner: xianglu@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e222cf23689ba10d8c7213591ff4bd6d6ab3c4bc

commit e222cf23689ba10d8c7213591ff4bd6d6ab3c4bc
Author: xianglu <xianglu@chromium.org>
Date: Sat Dec 17 00:19:34 2016

Barcode Detection: Add |cornerPoints| to DetectedBarcode.idl

This CL implements and wires |cornerPoints| field in DetectedBarcode.idl.

BUG= 673052 

Review-Url: https://codereview.chromium.org/2575943002
Cr-Commit-Position: refs/heads/master@{#439249}

[modify] https://crrev.com/e222cf23689ba10d8c7213591ff4bd6d6ab3c4bc/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java
[modify] https://crrev.com/e222cf23689ba10d8c7213591ff4bd6d6ab3c4bc/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js
[modify] https://crrev.com/e222cf23689ba10d8c7213591ff4bd6d6ab3c4bc/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e222cf23689ba10d8c7213591ff4bd6d6ab3c4bc/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
[modify] https://crrev.com/e222cf23689ba10d8c7213591ff4bd6d6ab3c4bc/third_party/WebKit/Source/modules/shapedetection/DEPS
[modify] https://crrev.com/e222cf23689ba10d8c7213591ff4bd6d6ab3c4bc/third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.cpp
[modify] https://crrev.com/e222cf23689ba10d8c7213591ff4bd6d6ab3c4bc/third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.h
[modify] https://crrev.com/e222cf23689ba10d8c7213591ff4bd6d6ab3c4bc/third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.idl
[modify] https://crrev.com/e222cf23689ba10d8c7213591ff4bd6d6ab3c4bc/third_party/WebKit/public/platform/modules/shapedetection/barcodedetection.mojom

Status: Fixed (was: Assigned)

Sign in to add a comment