New issue
Advanced search Search tips

Issue 673028 link

Starred by 1 user
Status: Fixed
Owner:
alexilin@chromium.org
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 9 2016 
"ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTQsSBUZsYWtlIkJSZXNvdXJjZVByZWZldGNoUHJlZGljdG9yQnJvd3NlclRlc3QuTGVhcm5pbmdKYXZhc2NyaXB0QXBwZW5kQ2hpbGQM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by asargent@chromium.org, Dec 10 2016

Owner: alexilin@chromium.org
Status: Assigned (was: Untriaged)
alexilin - looks like you recently added this test in https://codereview.chromium.org/2540803002, so assigning to you. 



Example failure from https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/331974/steps/browser_tests%20%28with%20patch%29/logs/ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild


ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild (run #1):
[ RUN      ] ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild
[4364:4716:1209/110634.152:WARNING:chrome_browser_main_win.cc(425)] Command line too long for RegisterApplicationRestart
[5108:5044:1209/110634.283:INFO:media_foundation_video_encode_accelerator_win.cc(307)] Windows versions earlier than 8 are not supported.
Expected: has 4 elements and there exists some permutation of elements such that:
 - element #0 is equal to [3,2,http://127.0.0.1:62936/predictors/append_child.html,http://127.0.0.1:62936/handled-by-test/image.png,4,2,,0,,1,0], and
 - element #1 is equal to [3,2,http://127.0.0.1:62936/predictors/append_child.html,http://127.0.0.1:62936/handled-by-test/script.js,3,2,,0,,1,0], and
 - element #2 is equal to [3,2,http://127.0.0.1:62936/predictors/append_child.html,http://127.0.0.1:62936/handled-by-test/style.css,2,5,,0,,1,0], and
 - element #3 is equal to [3,2,http://127.0.0.1:62936/predictors/append_child.html,http://127.0.0.1:62936/predictors/append_child.js,3,4,application/javascript,0,,1,0]
  Actual: { [3,2,http://127.0.0.1:62936/predictors/append_child.html,http://127.0.0.1:62936/handled-by-test/image.png,4,4,,0,,1,0], [3,2,http://127.0.0.1:62936/predictors/append_child.html,http://127.0.0.1:62936/handled-by-test/script.js,3,2,,0,,1,0], [3,2,http://127.0.0.1:62936/predictors/append_child.html,http://127.0.0.1:62936/handled-by-test/style.css,2,5,,0,,1,0], [3,2,http://127.0.0.1:62936/predictors/append_child.html,http://127.0.0.1:62936/predictors/append_child.js,3,4,application/javascript,0,,1,0] }, where the following matchers don't match any elements:
matcher #0: is equal to [3,2,http://127.0.0.1:62936/predictors/append_child.html,http://127.0.0.1:62936/handled-by-test/image.png,4,2,,0,,1,0]
and where the following elements don't match any matchers:
element #0: [3,2,http://127.0.0.1:62936/predictors/append_child.html,http://127.0.0.1:62936/handled-by-test/image.png,4,4,,0,,1,0]
[4364:4716:1209/110637.354:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild, where TypeParam =  and GetParam() =  (3442 ms)

ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild (run #2):
[ RUN      ] ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild
[3884:3340:1209/111203.645:WARNING:chrome_browser_main_win.cc(425)] Command line too long for RegisterApplicationRestart
[1112:4572:1209/111203.710:INFO:media_foundation_video_encode_accelerator_win.cc(307)] Windows versions earlier than 8 are not supported.
Expected: has 4 elements and there exists some permutation of elements such that:
 - element #0 is equal to [3,2,http://127.0.0.1:63909/predictors/append_child.html,http://127.0.0.1:63909/handled-by-test/image.png,4,2,,0,,1,0], and
 - element #1 is equal to [3,2,http://127.0.0.1:63909/predictors/append_child.html,http://127.0.0.1:63909/handled-by-test/script.js,3,2,,0,,1,0], and
 - element #2 is equal to [3,2,http://127.0.0.1:63909/predictors/append_child.html,http://127.0.0.1:63909/handled-by-test/style.css,2,5,,0,,1,0], and
 - element #3 is equal to [3,2,http://127.0.0.1:63909/predictors/append_child.html,http://127.0.0.1:63909/predictors/append_child.js,3,4,application/javascript,0,,1,0]
  Actual: { [3,2,http://127.0.0.1:63909/predictors/append_child.html,http://127.0.0.1:63909/handled-by-test/image.png,4,4,,0,,1,0], [3,2,http://127.0.0.1:63909/predictors/append_child.html,http://127.0.0.1:63909/handled-by-test/script.js,3,2,,0,,1,0], [3,2,http://127.0.0.1:63909/predictors/append_child.html,http://127.0.0.1:63909/handled-by-test/style.css,2,5,,0,,1,0], [3,2,http://127.0.0.1:63909/predictors/append_child.html,http://127.0.0.1:63909/predictors/append_child.js,3,4,application/javascript,0,,1,0] }, where the following matchers don't match any elements:
matcher #0: is equal to [3,2,http://127.0.0.1:63909/predictors/append_child.html,http://127.0.0.1:63909/handled-by-test/image.png,4,2,,0,,1,0]
and where the following elements don't match any matchers:
element #0: [3,2,http://127.0.0.1:63909/predictors/append_child.html,http://127.0.0.1:63909/handled-by-test/image.png,4,4,,0,,1,0]
[3884:3340:1209/111205.370:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild, where TypeParam =  and GetParam() =  (1820 ms)

ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild (run #3):
[ RUN      ] ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild
[5360:4948:1209/111205.740:WARNING:chrome_browser_main_win.cc(425)] Command line too long for RegisterApplicationRestart
[4084:1612:1209/111205.814:INFO:media_foundation_video_encode_accelerator_win.cc(307)] Windows versions earlier than 8 are not supported.
Expected: has 4 elements and there exists some permutation of elements such that:
 - element #0 is equal to [3,2,http://127.0.0.1:63915/predictors/append_child.html,http://127.0.0.1:63915/handled-by-test/image.png,4,2,,0,,1,0], and
 - element #1 is equal to [3,2,http://127.0.0.1:63915/predictors/append_child.html,http://127.0.0.1:63915/handled-by-test/script.js,3,2,,0,,1,0], and
 - element #2 is equal to [3,2,http://127.0.0.1:63915/predictors/append_child.html,http://127.0.0.1:63915/handled-by-test/style.css,2,5,,0,,1,0], and
 - element #3 is equal to [3,2,http://127.0.0.1:63915/predictors/append_child.html,http://127.0.0.1:63915/predictors/append_child.js,3,4,application/javascript,0,,1,0]
  Actual: { [3,2,http://127.0.0.1:63915/predictors/append_child.html,http://127.0.0.1:63915/handled-by-test/image.png,4,4,,0,,1,0], [3,2,http://127.0.0.1:63915/predictors/append_child.html,http://127.0.0.1:63915/handled-by-test/script.js,3,2,,0,,1,0], [3,2,http://127.0.0.1:63915/predictors/append_child.html,http://127.0.0.1:63915/handled-by-test/style.css,2,5,,0,,1,0], [3,2,http://127.0.0.1:63915/predictors/append_child.html,http://127.0.0.1:63915/predictors/append_child.js,3,4,application/javascript,0,,1,0] }, where the following matchers don't match any elements:
matcher #0: is equal to [3,2,http://127.0.0.1:63915/predictors/append_child.html,http://127.0.0.1:63915/handled-by-test/image.png,4,2,,0,,1,0]
and where the following elements don't match any matchers:
element #0: [3,2,http://127.0.0.1:63915/predictors/append_child.html,http://127.0.0.1:63915/handled-by-test/image.png,4,4,,0,,1,0]
[5360:4948:1209/111207.239:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild, where TypeParam =  and GetParam() =  (1597 ms)

ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild (run #4):
[ RUN      ] ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild
[4308:3896:1209/111207.658:WARNING:chrome_browser_main_win.cc(425)] Command line too long for RegisterApplicationRestart
[1732:5156:1209/111207.691:INFO:media_foundation_video_encode_accelerator_win.cc(307)] Windows versions earlier than 8 are not supported.
Expected: has 4 elements and there exists some permutation of elements such that:
 - element #0 is equal to [3,2,http://127.0.0.1:63921/predictors/append_child.html,http://127.0.0.1:63921/handled-by-test/image.png,4,2,,0,,1,0], and
 - element #1 is equal to [3,2,http://127.0.0.1:63921/predictors/append_child.html,http://127.0.0.1:63921/handled-by-test/script.js,3,2,,0,,1,0], and
 - element #2 is equal to [3,2,http://127.0.0.1:63921/predictors/append_child.html,http://127.0.0.1:63921/handled-by-test/style.css,2,5,,0,,1,0], and
 - element #3 is equal to [3,2,http://127.0.0.1:63921/predictors/append_child.html,http://127.0.0.1:63921/predictors/append_child.js,3,4,application/javascript,0,,1,0]
  Actual: { [3,2,http://127.0.0.1:63921/predictors/append_child.html,http://127.0.0.1:63921/handled-by-test/image.png,4,4,,0,,1,0], [3,2,http://127.0.0.1:63921/predictors/append_child.html,http://127.0.0.1:63921/handled-by-test/script.js,3,2,,0,,1,0], [3,2,http://127.0.0.1:63921/predictors/append_child.html,http://127.0.0.1:63921/handled-by-test/style.css,2,5,,0,,1,0], [3,2,http://127.0.0.1:63921/predictors/append_child.html,http://127.0.0.1:63921/predictors/append_child.js,3,4,application/javascript,0,,1,0] }, where the following matchers don't match any elements:
matcher #0: is equal to [3,2,http://127.0.0.1:63921/predictors/append_child.html,http://127.0.0.1:63921/handled-by-test/image.png,4,2,,0,,1,0]
and where the following elements don't match any matchers:
element #0: [3,2,http://127.0.0.1:63921/predictors/append_child.html,http://127.0.0.1:63921/handled-by-test/image.png,4,4,,0,,1,0]
[4308:5784:1209/111208.681:WARNING:embedded_test_server.cc(202)] Request not handled. Returning 404: /favicon.ico
[4308:3896:1209/111209.061:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild, where TypeParam =  and GetParam() =  (1514 ms)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ae700640b7237af3acc10025827497be8376aab

commit 8ae700640b7237af3acc10025827497be8376aab
Author: Antony Sargent <asargent@chromium.org>
Date: Mon Dec 12 18:54:12 2016

Disable flaky test

ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild was
detected to be flaky by chromium-try-flakes.

TBR=lizeb@chromium.org

BUG= 673028 

Review-Url: https://codereview.chromium.org/2564213002 .
Cr-Commit-Position: refs/heads/master@{#437907}

[modify] https://crrev.com/8ae700640b7237af3acc10025827497be8376aab/chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54585e4c963fadabad06fd785ba30df548f9ade6

commit 54585e4c963fadabad06fd785ba30df548f9ade6
Author: alexilin <alexilin@chromium.org>
Date: Mon Dec 12 23:38:58 2016

predictors: Fuzzy comparison of request priority for images.

The browser tests for ResourcePrefetchPredictor check that the actual
request priority is equal to the expected value. But for the images the
priority cannot be precisely defined because there is a race between the
preload scanner issuing fetch requests and frame view performing layout
and promoting priorities of all visible images.

BUG= 650253 , 673028 

Review-Url: https://codereview.chromium.org/2569723002
Cr-Commit-Position: refs/heads/master@{#437958}

[modify] https://crrev.com/54585e4c963fadabad06fd785ba30df548f9ade6/chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab182621e72a32aeb610b6368cda75ba63a9a6d1

commit ab182621e72a32aeb610b6368cda75ba63a9a6d1
Author: alexilin <alexilin@chromium.org>
Date: Tue Dec 13 08:17:17 2016

Revert of Disable flaky test (patchset #2 id:20001 of https://codereview.chromium.org/2564213002/ )

Reason for revert:
Test is no longer flaky.

Original issue's description:
> Disable flaky test
>
> ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild was
> detected to be flaky by chromium-try-flakes.
>
> TBR=lizeb@chromium.org
>
> BUG= 673028 
>
> Committed: https://crrev.com/8ae700640b7237af3acc10025827497be8376aab
> Cr-Commit-Position: refs/heads/master@{#437907}

TBR=asargent@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 673028 

Review-Url: https://codereview.chromium.org/2575453002
Cr-Commit-Position: refs/heads/master@{#438097}

[modify] https://crrev.com/ab182621e72a32aeb610b6368cda75ba63a9a6d1/chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc

Comment 5 by alexilin@chromium.org, Dec 13 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment