New issue
Advanced search Search tips

Issue 673022 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Create test suite for web navigation.

Project Member Reported by kkhorimoto@chromium.org, Dec 9 2016

Issue description

This is an umbrella bug for the test suite being created for the web/ layer's navigation code.

Design doc: go/web-navigation-test-suite
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7a4d89f56a89ebf6c65cbe5f568143f86cde70e

commit b7a4d89f56a89ebf6c65cbe5f568143f86cde70e
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Tue Dec 13 01:54:05 2016

Fix window.history.go() with no parameter.

BUG= 673022 

Review-Url: https://codereview.chromium.org/2565673003
Cr-Commit-Position: refs/heads/master@{#437982}

[modify] https://crrev.com/b7a4d89f56a89ebf6c65cbe5f568143f86cde70e/ios/web/web_state/js/resources/core.js

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/38f45ad7975e32f141b2dc003eacadbd3658d4f4

commit 38f45ad7975e32f141b2dc003eacadbd3658d4f4
Author: kkhorimoto <kkhorimoto@google.com>
Date: Wed Dec 14 00:08:47 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/367c11a19008d5a30b746521aeeb5f554eae416b

commit 367c11a19008d5a30b746521aeeb5f554eae416b
Author: kkhorimoto <kkhorimoto@google.com>
Date: Fri Dec 16 00:47:05 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97c65878672508dea30c898fab48c40d36491589

commit 97c65878672508dea30c898fab48c40d36491589
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Fri Dec 16 04:18:45 2016

Add functionality to window.history.go test page.

- Added back/forward buttons.
- Added pushState() button.  This is necessary because if the pushState
  call is executed by injected JavaScript, then the navigation is
  registered as a client redirect.
- Display placeholder state object string when a popstate event with a
  null state object is received.

BUG= 673022 

Review-Url: https://codereview.chromium.org/2583733002
Cr-Commit-Position: refs/heads/master@{#439020}

[modify] https://crrev.com/97c65878672508dea30c898fab48c40d36491589/ios/testing/data/http_server_files/history_go.html
[modify] https://crrev.com/97c65878672508dea30c898fab48c40d36491589/ios/testing/data/http_server_files/history_go.js

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5add67f24efc58d9b064ba508a08bf788c6bd293

commit 5add67f24efc58d9b064ba508a08bf788c6bd293
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Fri Jan 20 00:47:00 2017

Created test for window.location.replace().

The test is currently disabled, as location.replace() currently behaves
as location.assign().

BUG= 673022 

Review-Url: https://codereview.chromium.org/2598133002
Cr-Commit-Position: refs/heads/master@{#444894}

[modify] https://crrev.com/5add67f24efc58d9b064ba508a08bf788c6bd293/ios/web/navigation/window_location_inttest.mm

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/274da537e7c6531cf15a4145c408607df06e6b8f

commit 274da537e7c6531cf15a4145c408607df06e6b8f
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Fri Jan 20 01:22:54 2017

Created test for window.location.assign() with unresolvable URLs.

BUG= 673022 

Review-Url: https://codereview.chromium.org/2600693002
Cr-Commit-Position: refs/heads/master@{#444918}

[modify] https://crrev.com/274da537e7c6531cf15a4145c408607df06e6b8f/ios/web/navigation/window_location_inttest.mm

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4ffb06583d7125ca69577fe32056caa8c0d7399

commit d4ffb06583d7125ca69577fe32056caa8c0d7399
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Fri Jan 20 02:12:01 2017

Created test for window.location.replace() with unresolvable URLs.

BUG= 673022 

Review-Url: https://codereview.chromium.org/2601503003
Cr-Commit-Position: refs/heads/master@{#444952}

[modify] https://crrev.com/d4ffb06583d7125ca69577fe32056caa8c0d7399/ios/web/navigation/window_location_inttest.mm

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e63937d8dc5cf8ebbeb8706b4f7179f3d7d84ee5

commit e63937d8dc5cf8ebbeb8706b4f7179f3d7d84ee5
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Fri Jan 20 19:11:20 2017

Created a test for window.location.reload().

BUG= 673022 

Review-Url: https://codereview.chromium.org/2597133003
Cr-Commit-Position: refs/heads/master@{#445119}

[modify] https://crrev.com/e63937d8dc5cf8ebbeb8706b4f7179f3d7d84ee5/ios/web/navigation/window_location_inttest.mm

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95d35ca10ca853e71051e645596d8d4b19774cbc

commit 95d35ca10ca853e71051e645596d8d4b19774cbc
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Fri Jan 20 19:35:14 2017

Created a test for assigning a string to window.location.

BUG= 673022 

Review-Url: https://codereview.chromium.org/2594363003
Cr-Commit-Position: refs/heads/master@{#445131}

[modify] https://crrev.com/95d35ca10ca853e71051e645596d8d4b19774cbc/ios/web/navigation/window_location_inttest.mm

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83f3676db831f10d529b255fa73a651b26abc2a5

commit 83f3676db831f10d529b255fa73a651b26abc2a5
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Tue Jan 24 22:01:28 2017

Created test for title replacement via window.history.replaceState().

This is currently disabled, as NavigationItem title updating requires
a web delegate, which is not present in this test fixture.

BUG= 673022 

Review-Url: https://codereview.chromium.org/2606003002
Cr-Commit-Position: refs/heads/master@{#445830}

[modify] https://crrev.com/83f3676db831f10d529b255fa73a651b26abc2a5/ios/web/navigation/history_state_operations_inttest.mm

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4428bc124888dfc222699a7dc01ea24971c019da

commit 4428bc124888dfc222699a7dc01ea24971c019da
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Tue Jan 24 22:21:14 2017

Created test verifying setting the state object via replaceState()

BUG= 673022 

Review-Url: https://codereview.chromium.org/2602013002
Cr-Commit-Position: refs/heads/master@{#445838}

[modify] https://crrev.com/4428bc124888dfc222699a7dc01ea24971c019da/ios/web/navigation/history_state_operations_inttest.mm

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2b24b67da5f5bd50afe510e86b25888faba3d7d

commit c2b24b67da5f5bd50afe510e86b25888faba3d7d
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Tue Jan 24 22:47:23 2017

Created test verifying resetting the state object after reloading.

BUG= 673022 

Review-Url: https://codereview.chromium.org/2607603005
Cr-Commit-Position: refs/heads/master@{#445847}

[modify] https://crrev.com/c2b24b67da5f5bd50afe510e86b25888faba3d7d/ios/web/navigation/history_state_operations_inttest.mm

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b5d888f9c2513c1cf033ce7527e38a62b2eb9eb

commit 9b5d888f9c2513c1cf033ce7527e38a62b2eb9eb
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Tue Jan 24 23:30:33 2017

Created test for restoring state object after back/forward navigation.

BUG= 673022 

Review-Url: https://codereview.chromium.org/2604103002
Cr-Commit-Position: refs/heads/master@{#445858}

[modify] https://crrev.com/9b5d888f9c2513c1cf033ce7527e38a62b2eb9eb/ios/web/navigation/history_state_operations_inttest.mm

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99d6b7f8f877750caa5654d2c62594b3761fd1ad

commit 99d6b7f8f877750caa5654d2c62594b3761fd1ad
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Wed Jan 25 06:16:54 2017

Created test for window.history.pushState().

BUG= 673022 

Review-Url: https://codereview.chromium.org/2604123002
Cr-Commit-Position: refs/heads/master@{#445968}

[modify] https://crrev.com/99d6b7f8f877750caa5654d2c62594b3761fd1ad/ios/web/navigation/history_state_operations_inttest.mm

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a19de6794f474515099b0e54c1d7000b832ea64

commit 6a19de6794f474515099b0e54c1d7000b832ea64
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Wed Jan 25 19:36:06 2017

Created test verifying no hashchange event for replaceState() calls.

BUG= 673022 

Review-Url: https://codereview.chromium.org/2602023002
Cr-Commit-Position: refs/heads/master@{#446087}

[modify] https://crrev.com/6a19de6794f474515099b0e54c1d7000b832ea64/ios/web/navigation/history_state_operations_inttest.mm

Status: Fixed (was: Started)

Sign in to add a comment