New issue
Advanced search Search tips

Issue 672996 link

Starred by 3 users
Status: Fixed
Owner:
ma...@chromium.org
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Payment Request] Opening an editor for an element and canceling out unselects the element

Project Member Reported by ma...@chromium.org, Dec 9 2016 
Steps:

* Open the Payment Request UI
* Click the pencil on an element that is selected (this will open the editor for that element)
* "Cancel" out of that editor

Expected result:
Item is still selected

Actual:
Nothing is selected.

Comment 1 by ma...@chromium.org, Dec 9 2016 

Proposed fix in review at https://codereview.chromium.org/2561373002/ is attached.
prfix.mp4
2.3 MB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f8a29ea00d9ab273a33a42c77d4afe13a8707ac

commit 7f8a29ea00d9ab273a33a42c77d4afe13a8707ac
Author: mathp <mathp@chromium.org>
Date: Sat Dec 10 02:06:19 2016

[Payment Request] Keep selection for edited item when canceling editors

Previously, the various editors would return |null| to the caller
(PaymentRequestImpl) in the case of a cancel. We are now returning the
original item that was passed in for edit.

BUG= 672996 
TEST=PaymentRequest*Test*

Review-Url: https://codereview.chromium.org/2561373002
Cr-Commit-Position: refs/heads/master@{#437723}

[modify] https://crrev.com/7f8a29ea00d9ab273a33a42c77d4afe13a8707ac/chrome/android/java/res/layout/payment_option_edit_icon.xml
[modify] https://crrev.com/7f8a29ea00d9ab273a33a42c77d4afe13a8707ac/chrome/android/java/res/values/ids.xml
[modify] https://crrev.com/7f8a29ea00d9ab273a33a42c77d4afe13a8707ac/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
[modify] https://crrev.com/7f8a29ea00d9ab273a33a42c77d4afe13a8707ac/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/7f8a29ea00d9ab273a33a42c77d4afe13a8707ac/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java
[modify] https://crrev.com/7f8a29ea00d9ab273a33a42c77d4afe13a8707ac/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/7f8a29ea00d9ab273a33a42c77d4afe13a8707ac/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
[modify] https://crrev.com/7f8a29ea00d9ab273a33a42c77d4afe13a8707ac/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
[modify] https://crrev.com/7f8a29ea00d9ab273a33a42c77d4afe13a8707ac/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
[modify] https://crrev.com/7f8a29ea00d9ab273a33a42c77d4afe13a8707ac/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppAndCardsTest.java
[modify] https://crrev.com/7f8a29ea00d9ab273a33a42c77d4afe13a8707ac/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java
[modify] https://crrev.com/7f8a29ea00d9ab273a33a42c77d4afe13a8707ac/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Comment 3 by ma...@chromium.org, Dec 10 2016

Status: Fixed (was: Started)

Comment 4 by rouslan@chromium.org, Dec 12 2016 

Issue 631972 has been merged into this issue.

Comment 5 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment