New issue
Advanced search Search tips

Issue 672990 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 672293

Blocking:
issue 634166



Sign in to add a comment

Allow an app to trigger touchscreen calibration/association

Project Member Reported by abodenha@chromium.org, Dec 9 2016

Issue description

Kiosk apps can currently trigger monitor calibration with chrome.system.display.overscan*

We need a similar set of APIs to allow apps to invoke the new touch calibration UI.

Would love to get this into 57, but I'm guessing 58 is more realistic.
 
This is already a part of the touchscreen calibration being implemented.

The API methods are already available to 1)set touch screen calibration as well as 2)start the inbuilt touch screen calibration UX. https://cs.chromium.org/chromium/src/extensions/common/api/system_display.idl?rcl=0&l=280


1) Setting Calibration Data: Currently the calibration data can be set using the API.
The CL related to utilising this calibration data is yet to be checked in and is currently under review. Rest of the piping is already complete and checked in.
(Corresponding CL: https://codereview.chromium.org/2557163002)

2) Starting the native calibration process via the API: Despite the API interface being available, its implementation is yet to be checked in. This will have to be punted to M58.
Blockedon: 672293
Blocking: 634166
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/795de01a5f04ab858c07e0af0ba56370eaae0aab

commit 795de01a5f04ab858c07e0af0ba56370eaae0aab
Author: malaykeshav <malaykeshav@chromium.org>
Date: Fri Dec 30 08:07:30 2016

Plumbs touch calibration API to the display manager

 - touchCalibrationSet() and touchCalibrationReset() API now work.
 - Fixes minor bug in TouchCalibratorController to allow graceful
   destruction during tests.
 - Updates DisplayInforProviderChromeOS unittests.

BUG= 667921 , 672990 
COMPONENT=Display Info Provider, Chrome OS, API, Touch Calibration

Review-Url: https://codereview.chromium.org/2603563002
Cr-Commit-Position: refs/heads/master@{#441022}

[modify] https://crrev.com/795de01a5f04ab858c07e0af0ba56370eaae0aab/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc
[modify] https://crrev.com/795de01a5f04ab858c07e0af0ba56370eaae0aab/chrome/browser/extensions/display_info_provider_chromeos.cc
[modify] https://crrev.com/795de01a5f04ab858c07e0af0ba56370eaae0aab/chrome/browser/extensions/display_info_provider_chromeos.h
[modify] https://crrev.com/795de01a5f04ab858c07e0af0ba56370eaae0aab/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
[modify] https://crrev.com/795de01a5f04ab858c07e0af0ba56370eaae0aab/extensions/browser/api/system_display/display_info_provider.cc
[modify] https://crrev.com/795de01a5f04ab858c07e0af0ba56370eaae0aab/extensions/browser/api/system_display/display_info_provider.h
[modify] https://crrev.com/795de01a5f04ab858c07e0af0ba56370eaae0aab/extensions/browser/api/system_display/system_display_api.cc

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f64df43034f52aea554ca764633c58a72f44831

commit 5f64df43034f52aea554ca764633c58a72f44831
Author: malaykeshav <malaykeshav@chromium.org>
Date: Fri Jan 20 02:09:42 2017

- Plumbs through native touch calibration from MD settings to
   display manager via the system display API.

Modifications done to System Display API:
 - Renames API method.
 - Splits touchCalibrationSet() method into 2 separate methods.
   (Why? https://docs.google.com/document/d/1fFvSk35wWRoKspJRR1hYMqlfeyhYO4l7s92g-5m9vPo/)

 - Updates SystemDisplayAPI Test

BUG= 672990 
COMPONENT=Display Info Provider, Chrome OS, System Display API, Touch Calibration
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2638903003
Cr-Commit-Position: refs/heads/master@{#444950}

[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.h
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/chrome/browser/extensions/display_info_provider_chromeos.cc
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/chrome/browser/extensions/display_info_provider_chromeos.h
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/chrome/browser/resources/settings/device_page/display.js
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/extensions/browser/api/system_display/display_info_provider.cc
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/extensions/browser/api/system_display/display_info_provider.h
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/extensions/browser/api/system_display/system_display_api.cc
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/extensions/browser/api/system_display/system_display_api.h
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/extensions/browser/api/system_display/system_display_apitest.cc
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/extensions/common/api/system_display.idl
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/third_party/closure_compiler/externs/system_display.js
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/third_party/closure_compiler/interfaces/system_display_interface.js
[modify] https://crrev.com/5f64df43034f52aea554ca764633c58a72f44831/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-57
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 23 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 23 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78cf3269633c9134933f70d6087faa42f440dd96

commit 78cf3269633c9134933f70d6087faa42f440dd96
Author: Jacob Dufault <jdufault@google.com>
Date: Mon Jan 23 20:25:29 2017

- Plumbs through native touch calibration from MD settings to    display manager via the system display API.

Modifications done to System Display API:
 - Renames API method.
 - Splits touchCalibrationSet() method into 2 separate methods.
   (Why? https://docs.google.com/document/d/1fFvSk35wWRoKspJRR1hYMqlfeyhYO4l7s92g-5m9vPo/)

 - Updates SystemDisplayAPI Test

BUG= 672990 
COMPONENT=Display Info Provider, Chrome OS, System Display API, Touch Calibration
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2638903003
Cr-Commit-Position: refs/heads/master@{#444950}
(cherry picked from commit 5f64df43034f52aea554ca764633c58a72f44831)

Review-Url: https://codereview.chromium.org/2656433004 .
Cr-Commit-Position: refs/branch-heads/2987@{#36}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.h
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/chrome/browser/extensions/display_info_provider_chromeos.cc
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/chrome/browser/extensions/display_info_provider_chromeos.h
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/chrome/browser/resources/settings/device_page/display.js
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/extensions/browser/api/system_display/display_info_provider.cc
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/extensions/browser/api/system_display/display_info_provider.h
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/extensions/browser/api/system_display/system_display_api.cc
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/extensions/browser/api/system_display/system_display_api.h
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/extensions/browser/api/system_display/system_display_apitest.cc
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/extensions/common/api/system_display.idl
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/third_party/closure_compiler/externs/system_display.js
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/third_party/closure_compiler/interfaces/system_display_interface.js
[modify] https://crrev.com/78cf3269633c9134933f70d6087faa42f440dd96/tools/metrics/histograms/histograms.xml

Cc: r...@chromium.org
Cc: -st...@chromium.org
Status: Verified (was: Fixed)

Sign in to add a comment