New issue
Advanced search Search tips

Issue 672989 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 648274
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

virtual/spinvalidation/fast/multicol/span/abspos-containing-block-outside-spanner.html fail

Project Member Reported by wangxianzhu@chromium.org, Dec 9 2016

Issue description

As title.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7390e830c109df123c871fda26ea889d64f2d198

commit 7390e830c109df123c871fda26ea889d64f2d198
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Sat Dec 10 02:25:51 2016

[SPInvalidation] Workaround bug about out-of-flow positioned under column spanner

Force slow path for now, which is the same as what we are doing in
PaintInvalidationState.

BUG= 672989 
TEST=virtual/spinvalidation/fast/multicol/span/abspos-containing-block-outside-spanner.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2569483003
Cr-Commit-Position: refs/heads/master@{#437727}

[modify] https://crrev.com/7390e830c109df123c871fda26ea889d64f2d198/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7390e830c109df123c871fda26ea889d64f2d198/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

Blocking: -646176
Mergedinto: 648274
Status: Duplicate (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/119ea71ebf5726d177e02cfb426f999cd7a23278

commit 119ea71ebf5726d177e02cfb426f999cd7a23278
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Mon Jan 09 23:27:12 2017

Remove workaround for multicol spanner in PaintInvalidator

After https://codereview.chromium.org/2615203002/, the spanner case
is covered by the multicol case.

BUG= 672989 
TEST=fast/multicol/span/abspos-containing-block-outside-spanner.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2626523002
Cr-Commit-Position: refs/heads/master@{#442399}

[modify] https://crrev.com/119ea71ebf5726d177e02cfb426f999cd7a23278/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

Sign in to add a comment