New issue
Advanced search Search tips

Issue 672988 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 672152



Sign in to add a comment

Add a unit test for failure case with the expected result.

Project Member Reported by hongchan@chromium.org, Dec 9 2016

Issue description

The unit test for audit.js only covers basic/successful cases. Add another unit test that tests failure cases with the expected text result.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e373ad9f97f06bf8e44ead4ad51c0500bb98afee

commit e373ad9f97f06bf8e44ead4ad51c0500bb98afee
Author: hongchan <hongchan@chromium.org>
Date: Tue Dec 20 02:54:04 2016

Additional unit test for audit.js: failure cases and logging examples.

The unit test for audit.js only covers basic/successful cases.
This CL is to add another unit test that tests failure cases with the
expected text result.

In the course of refining the failure output message, some editorial
edits also have been made in audit.js.

BUG= 672988 
TEST=LayoutTests/webaudio/unit-tests/audit-failures.html

Review-Url: https://codereview.chromium.org/2568573002
Cr-Commit-Position: refs/heads/master@{#439681}

[modify] https://crrev.com/e373ad9f97f06bf8e44ead4ad51c0500bb98afee/third_party/WebKit/LayoutTests/webaudio/resources/audit.js
[add] https://crrev.com/e373ad9f97f06bf8e44ead4ad51c0500bb98afee/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt
[add] https://crrev.com/e373ad9f97f06bf8e44ead4ad51c0500bb98afee/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures-expected.txt
[add] https://crrev.com/e373ad9f97f06bf8e44ead4ad51c0500bb98afee/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
[modify] https://crrev.com/e373ad9f97f06bf8e44ead4ad51c0500bb98afee/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html

Status: Verified (was: Assigned)

Sign in to add a comment