New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672969 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Modify IAccessible2 to use the new word and line boundary logic based on AXPosition

Project Member Reported by nek...@chromium.org, Dec 9 2016

Issue description

content::AXPlatformPosition now includes methods for returning character, word and line boundaries. We should replace our current implementation of IAccessibleText with this more robust and platform independent code.

 

Comment 1 by chaok@google.com, Dec 9 2016

From Joe @FS:
"I was just talking to a colligue about this issue. Regardless of how we do it, we have the issue of not including the non-editable marker in the offsets for Braille routing etc. We will need to know that we are in a list (perhaps an object attribute?) and how many characters to account for the list item at the beginning (another object attribute???) so that we can adjust the offsets for Braille routing and cursor tracking. Any time we have extra characters in the text which are non-navigable, we must somehow account for them so that the cursor blinks under the correct character. Whatever solution you come up with, will require work to ensure that the cursor is placed under the correct character when we output to Braille. Plese keep this in mind and let us know which route you take and how we can obtain the information necessary to keep cursor tracking correct.
For example, in a list item whose number is 100 folowed by a space before the main text of the line, the offset of the line really begins at 4 and the list item marker length is 4."
Labels: NewComponent-Accessibility NewComponent-Accessibility-Compatibility
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfe0ed4a9362cae34fe04555791f34b05cb21457

commit dfe0ed4a9362cae34fe04555791f34b05cb21457
Author: nektar <nektar@chromium.org>
Date: Wed Apr 12 03:33:26 2017

Switched to using |AXPosition| for calculating word and line boundaries on Windows.

These are enough changes for one patch but followup patches need to:
1. Switch to using |AXPosition| for character boundaries and get rid of ui::FindAccessibleTextBoundary.
2. Fix all bugs with SetSelection in Blink and get rid of Windows specific workarounds.
BUG= 672969 
R=dmazzoni@chromium.org
TESTED=manual testing, browser tests

Review-Url: https://codereview.chromium.org/2806773002
Cr-Commit-Position: refs/heads/master@{#463920}

[modify] https://crrev.com/dfe0ed4a9362cae34fe04555791f34b05cb21457/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/dfe0ed4a9362cae34fe04555791f34b05cb21457/content/browser/accessibility/ax_platform_position.cc
[modify] https://crrev.com/dfe0ed4a9362cae34fe04555791f34b05cb21457/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/dfe0ed4a9362cae34fe04555791f34b05cb21457/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/dfe0ed4a9362cae34fe04555791f34b05cb21457/content/browser/accessibility/browser_accessibility_manager.cc
[modify] https://crrev.com/dfe0ed4a9362cae34fe04555791f34b05cb21457/content/browser/accessibility/browser_accessibility_manager_unittest.cc
[modify] https://crrev.com/dfe0ed4a9362cae34fe04555791f34b05cb21457/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/dfe0ed4a9362cae34fe04555791f34b05cb21457/content/browser/accessibility/browser_accessibility_win.h
[modify] https://crrev.com/dfe0ed4a9362cae34fe04555791f34b05cb21457/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/dfe0ed4a9362cae34fe04555791f34b05cb21457/ui/accessibility/ax_position.h

Components: UI>Accessibility>Compatibility
Components: -UI>Accessibility
Labels: -newcomponent-accessibility-compatibility -newcomponent-accessibility
Labels: triage-nektar

Comment 7 by nek...@chromium.org, Dec 10 2017

Status: Fixed (was: Available)

Sign in to add a comment