New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672961 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 7
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment

[Meta] Make Exo work on Mus+Ash

Project Member Reported by fsam...@chromium.org, Dec 9 2016

Issue description

Exo should work on Mus+Ash.

 
Labels: Proj-Mustash
exo::Surface should not be creating CompositorFrameSinks directly. Instead, it should ask the aura::WindowPort for a CompositorFrameSink. That way, it won't need to allocate its own FrameSinkId and it won't need to register its own BeginFrame hierarchy. The WindowPort should take care of these details.
Blockedon: 678270
Blocking: 601863
Status: Available (was: Untriaged)
Owner: penghuang@chromium.org
Status: Assigned (was: Available)
Blockedon: 728131
Blockedon: 728695
Blockedon: -678270
Blockedon: 697584
Blockedon: 697587
Blockedon: 731742
Blocking: -601863
Blockedon: 727775
Blockedon: 678270
Blockedon: -678270
Blockedon: -697584
Blockedon: -697587
Blockedon: -727775
Blockedon: 767990
Blockedon: 768395
Blocking: 768439
Project Member

Comment 23 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a46057701d214b4ee9d505a770c8a89c8090f64

commit 0a46057701d214b4ee9d505a770c8a89c8090f64
Author: Peng Huang <penghuang@chromium.org>
Date: Mon Sep 25 18:56:54 2017

Don't run wayland server in browser process for mash

Bug:  672961 
Change-Id: Ie6debbe816a7ec24fb0934d9d20fc446e55868f2
Reviewed-on: https://chromium-review.googlesource.com/682105
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504115}
[modify] https://crrev.com/0a46057701d214b4ee9d505a770c8a89c8090f64/chrome/browser/exo_parts.cc

Blockedon: 766184
Blockedon: 772382
Project Member

Comment 26 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87a65cd5fee07a6e0835000ba44fd2be757526fa

commit 87a65cd5fee07a6e0835000ba44fd2be757526fa
Author: Peng Huang <penghuang@chromium.org>
Date: Fri Oct 06 15:21:47 2017

Run exo in ash process for mus+ash

For short term, we would like to run exo and ash in the same process.
It should have good performance. If not, we may consider other options.

Known issues:
 * The notification doesn't work.
 * The ChromeFileHelper isn't implemented.

Bug:  672961 
Change-Id: Ia80124593f55654303cf20d9d63971db10d18449
Reviewed-on: https://chromium-review.googlesource.com/682652
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507077}
[modify] https://crrev.com/87a65cd5fee07a6e0835000ba44fd2be757526fa/ash/mus/BUILD.gn
[modify] https://crrev.com/87a65cd5fee07a6e0835000ba44fd2be757526fa/ash/mus/window_manager.cc
[modify] https://crrev.com/87a65cd5fee07a6e0835000ba44fd2be757526fa/ash/mus/window_manager.h
[modify] https://crrev.com/87a65cd5fee07a6e0835000ba44fd2be757526fa/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/87a65cd5fee07a6e0835000ba44fd2be757526fa/ash/public/cpp/ash_switches.h
[add] https://crrev.com/87a65cd5fee07a6e0835000ba44fd2be757526fa/ash/wayland/BUILD.gn
[add] https://crrev.com/87a65cd5fee07a6e0835000ba44fd2be757526fa/ash/wayland/DEPS
[add] https://crrev.com/87a65cd5fee07a6e0835000ba44fd2be757526fa/ash/wayland/OWNERS
[add] https://crrev.com/87a65cd5fee07a6e0835000ba44fd2be757526fa/ash/wayland/wayland_server_controller.cc
[add] https://crrev.com/87a65cd5fee07a6e0835000ba44fd2be757526fa/ash/wayland/wayland_server_controller.h
[modify] https://crrev.com/87a65cd5fee07a6e0835000ba44fd2be757526fa/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/87a65cd5fee07a6e0835000ba44fd2be757526fa/components/exo/wm_helper_ash.cc

Blockedon: 774126
Blockedon: 774514
Cc: xiy...@chromium.org
Could we have a simple one-pager to document how exo work in mash?
The current plan is putting exo in ash(WM) in the same process. And we will measure the exo performance. The plan will not be changed, unless we find unacceptable performance regression.
Re #30: Thanks for the heads up.
Labels: -Proj-Mustash Proj-Mash-SingleProcess
Cc: penghuang@chromium.org
Owner: ----
Status: Available (was: Assigned)
Not working on exo, so mark it as available.
Owner: xiy...@chromium.org
Status: Assigned (was: Available)
Xiyuan, could you see what needs to be done here for single-process-mash. I'm hoping it just works, but I could certainly be wrong.
Labels: Pri-2
Owner: mukai@chromium.org
Jun, any chance you could try ARC++ and ensure it works with single-process-mash?
It seems it basically works; I confirmed Angry Birds is playable.
However it can't play video of YouTube app, possibly because of  issue 774514 .

Also crostini app icons aren't ideal, don't know why.
Sorry I was wrong, it seems working after re-imaged to R72-11244.0.0 (for my development). It could be a transient error due to the developer-built binaries.
Filed  issue 905802  for the crostini apps
Status: Fixed (was: Assigned)
I'm going to move this to fixed. Any issues that come up (such as  bug 905802 ) will be handled appropriately.

Sign in to add a comment