New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672955 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: 2016-12-10
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

[CVox Next] ChromeVox crash when opening the gmail shortcuts menu list

Project Member Reported by lpalmaro@chromium.org, Dec 9 2016

Issue description

 If you are in gmail and press Shift forward slash to open the shortcuts menu, ChromeVox Next totally freezes. The only way to get out of the menu is to press escape, but you don’t get any spoken feedback. Then the only way to get any speech at all is to turn ChromeVox off and on again. This doesn’t appear to be happening in Classic though. 



 
Summary: [CVox Next] ChromeVox crash when opening the gmail shortcuts menu list (was: [CVox Next] Gmail crash when opening the gmail shortcuts menu list )
Components: UI>Accessibility

Comment 3 by chaok@google.com, Dec 10 2016

Labels: -Pri-2 Pri-1
NextAction: 2016-12-10

Comment 4 by dtseng@chromium.org, Dec 12 2016

Labels: M-56
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a740f7ec72a6bf88e269f52c5561dd57ffde1589

commit a740f7ec72a6bf88e269f52c5561dd57ffde1589
Author: dtseng <dtseng@chromium.org>
Date: Mon Dec 12 22:08:09 2016

Fix issues with sending tts queue lots of utterances

- $descendants for div's can be very expensive. For example, in Gmail, there is a focusable div that wraps almost the entire contents of the page. We end up generating Output for everything under the div and lag significantly when focus lands here.
Fix this by only taking the text content of divs as one large string.  $descendants had all output including rich formatting.
- live region output on alerts causes double output (and similar lag). For example, pressing '?' in Gmail triggers hundreds of runs inside of LiveRegion.
Fix this by ignoring live regions set on alert nodes.

TEST=navigate in Gmail.
BUG= 672955 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2563173002
Cr-Commit-Position: refs/heads/master@{#437925}

[modify] https://crrev.com/a740f7ec72a6bf88e269f52c5561dd57ffde1589/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/a740f7ec72a6bf88e269f52c5561dd57ffde1589/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js
[modify] https://crrev.com/a740f7ec72a6bf88e269f52c5561dd57ffde1589/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
[modify] https://crrev.com/a740f7ec72a6bf88e269f52c5561dd57ffde1589/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Comment 6 by dtseng@chromium.org, Dec 12 2016

Labels: Merge-Request-56
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/120bb61b5fd467ef232a893bd7b040fc208ee4c4

commit 120bb61b5fd467ef232a893bd7b040fc208ee4c4
Author: dtseng <dtseng@chromium.org>
Date: Tue Dec 13 06:26:55 2016

Improve the speech panel's performance

Currently, ChromeVox sends all queued speech output to the speech panel.

This unfortunately causes performance issues.

For example, in Gmail, if ChromeVox sends ~500 utterances, which can happen if we have a large block of text (since we split on sentences), ChromeVox stops responding to key commands.

ChromeVox should stay responsive in any situation especially if a user taps on the control key repeatedly.

This change makes it so we only show the currently spoken text which gets around the potentially expensive calls to send text to the panel background page (which blocks).

BUG= 672955 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2570593002
Cr-Commit-Position: refs/heads/master@{#438083}

[modify] https://crrev.com/120bb61b5fd467ef232a893bd7b040fc208ee4c4/chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js

Labels: Merge-Approved-56
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 13 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc01623505fb20e30e21fc34614801be58758e56

commit cc01623505fb20e30e21fc34614801be58758e56
Author: David Tseng <dtseng@chromium.org>
Date: Tue Dec 13 23:29:23 2016

Improve the speech panel's performance

Currently, ChromeVox sends all queued speech output to the speech panel.

This unfortunately causes performance issues.

For example, in Gmail, if ChromeVox sends ~500 utterances, which can happen if we have a large block of text (since we split on sentences), ChromeVox stops responding to key commands.

ChromeVox should stay responsive in any situation especially if a user taps on the control key repeatedly.

This change makes it so we only show the currently spoken text which gets around the potentially expensive calls to send text to the panel background page (which blocks).

BUG= 672955 
TBR=dtseng@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2570593002
Cr-Commit-Position: refs/heads/master@{#438083}
(cherry picked from commit 120bb61b5fd467ef232a893bd7b040fc208ee4c4)

Review-Url: https://codereview.chromium.org/2574013002 .
Cr-Commit-Position: refs/branch-heads/2924@{#478}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/cc01623505fb20e30e21fc34614801be58758e56/chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0f1e3d1b5534b5b963f26f4e9e096ef3bc44bee

commit d0f1e3d1b5534b5b963f26f4e9e096ef3bc44bee
Author: David Tseng <dtseng@chromium.org>
Date: Tue Dec 13 23:42:17 2016

Merge to m56: Fix issues with sending tts queue lots of utterances

- $descendants for div's can be very expensive. For example, in Gmail, there is a focusable div that wraps almost the entire contents of the page. We end up generating Output for everything under the div and lag significantly when focus lands here.
Fix this by only taking the text content of divs as one large string.  $descendants had all output including rich formatting.
- live region output on alerts causes double output (and similar lag). For example, pressing '?' in Gmail triggers hundreds of runs inside of LiveRegion.
Fix this by ignoring live regions set on alert nodes.

TEST=navigate in Gmail.
BUG= 672955 
TBR=dtseng@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2563173002
Cr-Commit-Position: refs/heads/master@{#437925}
(cherry picked from commit a740f7ec72a6bf88e269f52c5561dd57ffde1589)

Review-Url: https://codereview.chromium.org/2571963002 .
Cr-Commit-Position: refs/branch-heads/2924@{#480}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/d0f1e3d1b5534b5b963f26f4e9e096ef3bc44bee/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/d0f1e3d1b5534b5b963f26f4e9e096ef3bc44bee/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js
[modify] https://crrev.com/d0f1e3d1b5534b5b963f26f4e9e096ef3bc44bee/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
[modify] https://crrev.com/d0f1e3d1b5534b5b963f26f4e9e096ef3bc44bee/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Comment 11 by dimu@chromium.org, Dec 14 2016

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
[Automated comment] There appears to be on-going work (i.e. bugroid changes), needs manual review.
Labels: -Hotlist-Merge-Review -Merge-Review-56
Status: fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment