Flywheel promo not shown until third run of Chrome |
||||||
Issue descriptionApplication Version (from "Chrome Settings > About Chrome"): 56.0.2924.18 Android Build Number (from "Android Settings > About Phone/Tablet"): LXI22.50-62 Device: Moto E Steps to reproduce: 1) Run Chrome. 2) Kill Chrome. 3) Run Chrome. 4) Kill Chrome. 5) Run Chrome. Observed behavior: The Flywheel "second run" promo shows on the third run of Chrome. Expected behavior: The promo should show on the second run. See internal doc for more details on experiment: https://docs.google.com/a/google.com/document/d/19ctmz25Dd4FsCUeFJeaIhWGBTENcVo5_KD626fRE4DM/edit?usp=sharing
,
Mar 30 2017
,
Apr 17 2017
Issue is also observed on M58: 58.0.3029.76
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/147bd1eedea8ce66f162faa43535d60137817d91 commit 147bd1eedea8ce66f162faa43535d60137817d91 Author: megjablon <megjablon@chromium.org> Date: Tue Apr 18 00:59:05 2017 Show DRP promo on second run The promo is currently being shown on second run because native initialization can finish before the FRE completes. Therefore the PROMOS_SKIPPED_ON_FIRST_START pref isn't set until the second run, and then the promo is shown on the third. BUG= 672954 Review-Url: https://codereview.chromium.org/2824893002 Cr-Commit-Position: refs/heads/master@{#465085} [modify] https://crrev.com/147bd1eedea8ce66f162faa43535d60137817d91/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
,
Apr 18 2017
,
Apr 18 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d436a66fe3ae362aa757fe2fa5a2819c599abb6 commit 0d436a66fe3ae362aa757fe2fa5a2819c599abb6 Author: Megan Jablonski <megjablon@google.com> Date: Tue Apr 18 18:42:46 2017 Show DRP promo on second run The promo is currently being shown on second run because native initialization can finish before the FRE completes. Therefore the PROMOS_SKIPPED_ON_FIRST_START pref isn't set until the second run, and then the promo is shown on the third. BUG= 672954 Review-Url: https://codereview.chromium.org/2824893002 Cr-Commit-Position: refs/heads/master@{#465085} (cherry picked from commit 147bd1eedea8ce66f162faa43535d60137817d91) Review-Url: https://codereview.chromium.org/2821393002 . Cr-Commit-Position: refs/branch-heads/3071@{#37} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/0d436a66fe3ae362aa757fe2fa5a2819c599abb6/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
,
Apr 18 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bengr@chromium.org
, Dec 22 2016Labels: M-57
Owner: megjab...@chromium.org