New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672950 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature



Sign in to add a comment

Move reporting of Variations headers to https only.

Project Member Reported by jwd@chromium.org, Dec 9 2016

Issue description

Currently Variations headers are reported to Google properties for http and https requests. We will move to only include these headers on https requests.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2016

Comment 3 by jwd@chromium.org, Dec 15 2016

Labels: M-56 Merge-Request-56

Comment 4 by dimu@chromium.org, Dec 15 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee267be79291d49bb28a84232128c39b2f67ced2

commit ee267be79291d49bb28a84232128c39b2f67ced2
Author: Jesse Doherty <jwd@chromium.org>
Date: Fri Dec 16 18:47:47 2016

Fixing histogram logging to better track variations headers https change.

BUG= 672950 

Review-Url: https://codereview.chromium.org/2575823003
Cr-Commit-Position: refs/heads/master@{#438605}
(cherry picked from commit a32d49767933c8642a9e4425b32f93bbbb7ef2c5)

Review-Url: https://codereview.chromium.org/2582723003 .
Cr-Commit-Position: refs/branch-heads/2924@{#529}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/ee267be79291d49bb28a84232128c39b2f67ced2/components/variations/net/variations_http_headers.cc
[modify] https://crrev.com/ee267be79291d49bb28a84232128c39b2f67ced2/tools/metrics/histograms/histograms.xml

Comment 7 by jwd@chromium.org, Jan 4 2017

Status: Fixed (was: Started)

Sign in to add a comment