New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 672945 link

Starred by 3 users
Status: Fixed
Owner:
█ ranj@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
█ amineer@chromium.org
█ ranj@chromium.org
w...@chromium.org
█ zpeng@chromium.org
█ wnwen@chromium.org
estevenson@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add a dump-on-java-assert build option

Project Member Reported by agrieve@chromium.org, Dec 9 2016 
We'd like to eventually enable android asserts on canary for short amounts of time. However, before doing so, we should make it so that java asserts can produce a crash dump without actually crashing the app (and annoying users).

This would be controlled behind a GN arg: java_assert_dump_and_continue = true.

This should additionally have guards against dumping the for the same assert more than once.

To enable this, we should change:
https://cs.chromium.org/chromium/src/build/android/java_assertion_enabler/

to call a function in base rather than directly throw an exception. The function in base can then choose to throw an exception, or just dump & continue based on the BuildConfig.CONTINUE_AFTER_FAILED_ASSERT value.

Comment 1 by w...@chromium.org, Dec 9 2016 

Would it make sense to hook this directly up to the same flag dump-on-DCHECK, or do you feel this is something you'd want to be able to enable/disable independently of more general DCHECK dumps?

Comment 2 by w...@chromium.org, Dec 9 2016

Cc: w...@chromium.org

Comment 3 by agrieve@chromium.org, Dec 9 2016 

Do we have a way to set flags at build-time? Otherwise I'm not sure how you'd enable it on android. 

It's also a bit weird that the flag wouldn't work if assertions are compiled out. Since you need a gn arg to have java asserts stay around, we might as well use a gn arg to define their behaviour (so you don't need a gn arg *and* a flag).

I'm also hopeful that we can enable asserts on canary / dev always (if the perf overhead will be negligible), so might be nice to control it separate from the DCHECK flag.

There could be some benefits to tying it to a flag as well though. I'm admittedly less familiar with how they work.

Comment 4 by w...@chromium.org, Dec 9 2016 

Re #3: Sorry, fuzzy wording on my part: dump-on-DCHECK is a *build-time option*, hence the question of whether we should use a single gn option to enable both DCHECK and Java assert-as-dump, since the two seem similar in spirit.

Comment 5 by agrieve@chromium.org, Dec 9 2016 

Ah okay. I think that would make sense then, as long as you could still turn on java asserts separately from DCHECKs (which I assume you could do via:

dcheck_always_on = false
dump_on_dcheck = true
enable_java_asserts = true

Comment 6 by w...@chromium.org, Dec 10 2016 

My current patches have dump_on_dcheck imply dcheck_always_on, but they
could of course be separated.

Comment 7 by agrieve@chromium.org, Dec 16 2016 

How about adding:

declare_args() {
  dump_on_java_assert = dump_on_dcheck
}

That way dump_on_dcheck implies dump_on_java_assert, but you can still toggle them separately.

Comment 8 by agrieve@chromium.org, Dec 20 2016 

note: refer to strict mode code for how to trigger a crash report without crashing:
ChromeStrictMode.reportStrictModeViolation()
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java

Comment 9 by yfried...@chromium.org, Jun 27 2017

Cc: ranj@chromium.org wnwen@chromium.org
Owner: ranj@chromium.org
+Ran as another stability wishlist item. For example impact: this would've caught  issue 735060  which took a lot of effort to track down but was much easier once I started triggering the assertion.

Are you sure we really don't want to crash in this case? This is basically like hitting a CHECK - shouldn't happen. Perhaps the first iteration we're more conservative?

Comment 10 by zpeng@chromium.org, Jun 27 2017

Cc: zpeng@chromium.org
If I recall correctly, this idea comes from an email thread discussion. We opted for dump instead of crash mostly because we didn't want to interrupt user experience for non-critical failures, e.g. assertion failure in UMA metrics.

From my experience, the Java asserts trigger quite often in flaky tests. This would be a nice feature to have.

Comment 11 by agrieve@chromium.org, Jun 27 2017 

asserts have always been disabled for release builds, so I think it's more fair to say they are the equivalent of DCHECK()s.

Comment 12 by ranj@chromium.org, Jun 29 2017

Cc: amineer@chromium.org
+ amineer

Are you OK with log crash dump in Java asserts without actual crashing in Canary build? Not sure how the size and performance will be affected by this.

Comment 13 by amineer@chromium.org, Jul 5 2017

Cc: -amineer@chromium.org
For one or two canaries, yes, that's fine.

If you want to do this continuously in perpetuity, then we need to discuss further.  Re-CC me with further questions.

Comment 14 by ranj@chromium.org, Jul 11 2017

Cc: amineer@chromium.org
+amineer

Hi Alex, seems there are some technical issues that we can't handle assert without crashing. Can we enable assert in one or two Canary?

Comment 15 by amineer@chromium.org, Jul 11 2017 

Enabling the assert in 1-2 canaries is OK, though you need to ensure you do it at a time when we're not trying to ship the same build to dev as that will make it hard to evaluate metrics.
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33133e5767a9c1ca1f7e9defad2d7b3347065589

commit 33133e5767a9c1ca1f7e9defad2d7b3347065589
Author: ranj <ranj@chromium.org>
Date: Wed Jul 19 17:31:44 2017

Create java_assertion_handler, a Java binary that takes in a JAR file
and modifies the bytecode of classes.

Replace the Java ASSERT with JavaExceptionReporter.assertFailureHandler
that throws Exception.

Output is written to a new JAR file.

BUG= 672945 

Review-Url: https://codereview.chromium.org/2971063003
Cr-Commit-Position: refs/heads/master@{#487903}

[modify] https://crrev.com/33133e5767a9c1ca1f7e9defad2d7b3347065589/base/android/java/src/org/chromium/base/JavaExceptionReporter.java
[modify] https://crrev.com/33133e5767a9c1ca1f7e9defad2d7b3347065589/base/android/java/src/org/chromium/base/process_launcher/ChildProcessLauncher.java
[modify] https://crrev.com/33133e5767a9c1ca1f7e9defad2d7b3347065589/build/android/java_assertion_enabler/java/org/chromium/javaassertionenabler/AssertionEnabler.java
[modify] https://crrev.com/33133e5767a9c1ca1f7e9defad2d7b3347065589/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
[modify] https://crrev.com/33133e5767a9c1ca1f7e9defad2d7b3347065589/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java
[modify] https://crrev.com/33133e5767a9c1ca1f7e9defad2d7b3347065589/chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImpl.java
[modify] https://crrev.com/33133e5767a9c1ca1f7e9defad2d7b3347065589/chrome/android/webapk/shell_apk/shell_apk_version.gni
[modify] https://crrev.com/33133e5767a9c1ca1f7e9defad2d7b3347065589/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserClassLoader.java
[modify] https://crrev.com/33133e5767a9c1ca1f7e9defad2d7b3347065589/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkSandboxedProcessService.java
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14d4eb4fdc5322d951fc70972d18d507bd5abe59

commit 14d4eb4fdc5322d951fc70972d18d507bd5abe59
Author: mgersh <mgersh@chromium.org>
Date: Wed Jul 19 18:07:50 2017

Revert of Handle Java assert using a customized function in base (patchset #8 id:390001 of https://codereview.chromium.org/2971063003/ )

Reason for revert:
Broke compile on Cronet bots with error about "can't find referenced class
org.chromium.base.JavaExceptionReporter": https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20x86%20Builder%20%28dbg%29/builds/61854

Original issue's description:
> Create java_assertion_handler, a Java binary that takes in a JAR file
> and modifies the bytecode of classes.
>
> Replace the Java ASSERT with JavaExceptionReporter.assertFailureHandler
> that throws Exception.
>
> Output is written to a new JAR file.
>
>
> BUG= 672945 
>
> Review-Url: https://codereview.chromium.org/2971063003
> Cr-Commit-Position: refs/heads/master@{#487903}
> Committed: https://chromium.googlesource.com/chromium/src/+/33133e5767a9c1ca1f7e9defad2d7b3347065589

TBR=yfriedman@chromium.org,agrieve@chromium.org,zpeng@chromium.org,ranj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 672945 

Review-Url: https://codereview.chromium.org/2981273003
Cr-Commit-Position: refs/heads/master@{#487914}

[modify] https://crrev.com/14d4eb4fdc5322d951fc70972d18d507bd5abe59/base/android/java/src/org/chromium/base/JavaExceptionReporter.java
[modify] https://crrev.com/14d4eb4fdc5322d951fc70972d18d507bd5abe59/base/android/java/src/org/chromium/base/process_launcher/ChildProcessLauncher.java
[modify] https://crrev.com/14d4eb4fdc5322d951fc70972d18d507bd5abe59/build/android/java_assertion_enabler/java/org/chromium/javaassertionenabler/AssertionEnabler.java
[modify] https://crrev.com/14d4eb4fdc5322d951fc70972d18d507bd5abe59/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
[modify] https://crrev.com/14d4eb4fdc5322d951fc70972d18d507bd5abe59/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java
[modify] https://crrev.com/14d4eb4fdc5322d951fc70972d18d507bd5abe59/chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImpl.java
[modify] https://crrev.com/14d4eb4fdc5322d951fc70972d18d507bd5abe59/chrome/android/webapk/shell_apk/shell_apk_version.gni
[modify] https://crrev.com/14d4eb4fdc5322d951fc70972d18d507bd5abe59/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserClassLoader.java
[modify] https://crrev.com/14d4eb4fdc5322d951fc70972d18d507bd5abe59/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkSandboxedProcessService.java
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bef3daf02ae6035f166782025fd7e4e54d465271

commit bef3daf02ae6035f166782025fd7e4e54d465271
Author: ranj <ranj@chromium.org>
Date: Thu Jul 20 20:20:50 2017

Create java_assertion_handler, a Java binary that takes in a JAR file
and modifies the bytecode of classes.

Replace the Java ASSERT with JavaExceptionReporter.assertFailureHandler
that throws Exception.

Output is written to a new JAR file.

BUG= 672945 

Review-Url: https://codereview.chromium.org/2971063003
Cr-Original-Commit-Position: refs/heads/master@{#487903}
Committed: https://chromium.googlesource.com/chromium/src/+/33133e5767a9c1ca1f7e9defad2d7b3347065589
Review-Url: https://codereview.chromium.org/2971063003
Cr-Commit-Position: refs/heads/master@{#488381}

[modify] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/base/BUILD.gn
[modify] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/base/android/java/src/org/chromium/base/JavaExceptionReporter.java
[modify] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/base/android/java/src/org/chromium/base/process_launcher/ChildProcessLauncher.java
[modify] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/build/android/BUILD.gn
[add] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/build/android/buildhooks/java/org/chromium/buildhooks/BuildHooks.java
[add] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/build/android/buildhooks/java/org/chromium/buildhooks/Callback.java
[modify] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/build/android/java_assertion_enabler/java/org/chromium/javaassertionenabler/AssertionEnabler.java
[modify] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/build/config/android/internal_rules.gni
[modify] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/chrome/android/BUILD.gn
[modify] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncher.java
[modify] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[modify] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
[modify] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java
[modify] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImpl.java
[modify] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/chrome/android/webapk/shell_apk/shell_apk_version.gni
[modify] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserClassLoader.java
[modify] https://crrev.com/bef3daf02ae6035f166782025fd7e4e54d465271/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkSandboxedProcessService.java
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83b7815399e50c9f9da3434669eba2829c2857e0

commit 83b7815399e50c9f9da3434669eba2829c2857e0
Author: estevenson <estevenson@chromium.org>
Date: Thu Jul 20 20:36:03 2017

Revert of Handle Java assert using a customized function in base (patchset #11 id:470001 of https://codereview.chromium.org/2971063003/ )

Reason for revert:
Reland changes weren't reviewed

Original issue's description:
> Create java_assertion_handler, a Java binary that takes in a JAR file
> and modifies the bytecode of classes.
>
> Replace the Java ASSERT with JavaExceptionReporter.assertFailureHandler
> that throws Exception.
>
> Output is written to a new JAR file.
>
>
> BUG= 672945 
>
> Review-Url: https://codereview.chromium.org/2971063003
> Cr-Original-Commit-Position: refs/heads/master@{#487903}
> Committed: https://chromium.googlesource.com/chromium/src/+/33133e5767a9c1ca1f7e9defad2d7b3347065589
> Review-Url: https://codereview.chromium.org/2971063003
> Cr-Commit-Position: refs/heads/master@{#488381}
> Committed: https://chromium.googlesource.com/chromium/src/+/bef3daf02ae6035f166782025fd7e4e54d465271

TBR=yfriedman@chromium.org,agrieve@chromium.org,zpeng@chromium.org,ranj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 672945 

Review-Url: https://codereview.chromium.org/2985613002
Cr-Commit-Position: refs/heads/master@{#488390}

[modify] https://crrev.com/83b7815399e50c9f9da3434669eba2829c2857e0/base/BUILD.gn
[modify] https://crrev.com/83b7815399e50c9f9da3434669eba2829c2857e0/base/android/java/src/org/chromium/base/JavaExceptionReporter.java
[modify] https://crrev.com/83b7815399e50c9f9da3434669eba2829c2857e0/base/android/java/src/org/chromium/base/process_launcher/ChildProcessLauncher.java
[modify] https://crrev.com/83b7815399e50c9f9da3434669eba2829c2857e0/build/android/BUILD.gn
[delete] https://crrev.com/8edea85f2496fd302770121d083591da5c87ad8f/build/android/buildhooks/java/org/chromium/buildhooks/BuildHooks.java
[delete] https://crrev.com/8edea85f2496fd302770121d083591da5c87ad8f/build/android/buildhooks/java/org/chromium/buildhooks/Callback.java
[modify] https://crrev.com/83b7815399e50c9f9da3434669eba2829c2857e0/build/android/java_assertion_enabler/java/org/chromium/javaassertionenabler/AssertionEnabler.java
[modify] https://crrev.com/83b7815399e50c9f9da3434669eba2829c2857e0/build/config/android/internal_rules.gni
[modify] https://crrev.com/83b7815399e50c9f9da3434669eba2829c2857e0/chrome/android/BUILD.gn
[modify] https://crrev.com/83b7815399e50c9f9da3434669eba2829c2857e0/chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncher.java
[modify] https://crrev.com/83b7815399e50c9f9da3434669eba2829c2857e0/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[modify] https://crrev.com/83b7815399e50c9f9da3434669eba2829c2857e0/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
[modify] https://crrev.com/83b7815399e50c9f9da3434669eba2829c2857e0/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java
[modify] https://crrev.com/83b7815399e50c9f9da3434669eba2829c2857e0/chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImpl.java
[modify] https://crrev.com/83b7815399e50c9f9da3434669eba2829c2857e0/chrome/android/webapk/shell_apk/shell_apk_version.gni
[modify] https://crrev.com/83b7815399e50c9f9da3434669eba2829c2857e0/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserClassLoader.java
[modify] https://crrev.com/83b7815399e50c9f9da3434669eba2829c2857e0/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkSandboxedProcessService.java
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c1e906dff6f894589b40fd2fde6a3d387cf8ef7

commit 7c1e906dff6f894589b40fd2fde6a3d387cf8ef7
Author: Ran Ji <ranj@chromium.org>
Date: Fri Jul 28 16:22:53 2017

Reland: Handle Java assert failure using BuildHooks.assertFailureHandler.

Handle Java assert failure by modifying the bytecode of jar file.
Create package org.chromium.build that have all java target depend on it.

Reland for CL https://codereview.chromium.org/2971063003/

BUG= 672945 

Change-Id: I9e22961c257e3a4c1b95a7b9add7e776164c7713
Reviewed-on: https://chromium-review.googlesource.com/580403
Commit-Queue: Ran Ji <ranj@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490420}
[modify] https://crrev.com/7c1e906dff6f894589b40fd2fde6a3d387cf8ef7/base/android/java/src/org/chromium/base/process_launcher/ChildProcessLauncher.java
[modify] https://crrev.com/7c1e906dff6f894589b40fd2fde6a3d387cf8ef7/build/android/BUILD.gn
[add] https://crrev.com/7c1e906dff6f894589b40fd2fde6a3d387cf8ef7/build/android/buildhooks/java/org/chromium/build/BuildHooks.java
[add] https://crrev.com/7c1e906dff6f894589b40fd2fde6a3d387cf8ef7/build/android/buildhooks/java/org/chromium/build/Callback.java
[modify] https://crrev.com/7c1e906dff6f894589b40fd2fde6a3d387cf8ef7/build/android/java_assertion_enabler/java/org/chromium/javaassertionenabler/AssertionEnabler.java
[modify] https://crrev.com/7c1e906dff6f894589b40fd2fde6a3d387cf8ef7/build/config/android/internal_rules.gni
[modify] https://crrev.com/7c1e906dff6f894589b40fd2fde6a3d387cf8ef7/chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncher.java
[modify] https://crrev.com/7c1e906dff6f894589b40fd2fde6a3d387cf8ef7/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
[modify] https://crrev.com/7c1e906dff6f894589b40fd2fde6a3d387cf8ef7/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java
Project Member

Comment 21 by bugdroid1@chromium.org, Aug 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e50b8d5a4d8523abba6780a44c4d5716824f681

commit 8e50b8d5a4d8523abba6780a44c4d5716824f681
Author: Eric Stevenson <estevenson@chromium.org>
Date: Tue Aug 15 19:10:47 2017

Android: Add BuildHooksAndroid.java.

This CL introduces BuildHooksAndroid, a class inserted at build
time to every Java library that requires Android. It also adds a
default BuildHooksAndroidImpl class that is used unless an
android_apk target is supplied a different implementation via
build_hooks_android_impl_deps.

These classes will primarily be used for bytecode rewriting.

Bug: 695304,  672945 
Change-Id: Iaaf13a4797e2035bcf8bd954d13f4160dbd8608b
Reviewed-on: https://chromium-review.googlesource.com/614061
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494479}
[modify] https://crrev.com/8e50b8d5a4d8523abba6780a44c4d5716824f681/build/android/BUILD.gn
[add] https://crrev.com/8e50b8d5a4d8523abba6780a44c4d5716824f681/build/android/buildhooks/BUILD.gn
[modify] https://crrev.com/8e50b8d5a4d8523abba6780a44c4d5716824f681/build/android/buildhooks/java/org/chromium/build/BuildHooks.java
[add] https://crrev.com/8e50b8d5a4d8523abba6780a44c4d5716824f681/build/android/buildhooks/java/org/chromium/build/BuildHooksAndroid.java
[add] https://crrev.com/8e50b8d5a4d8523abba6780a44c4d5716824f681/build/android/buildhooks/java/org/chromium/build/BuildHooksAndroidImpl.java
[delete] https://crrev.com/c8783a003d23fb51f4a8d37651b433a49874e63a/build/android/buildhooks/java/org/chromium/build/Callback.java
[modify] https://crrev.com/8e50b8d5a4d8523abba6780a44c4d5716824f681/build/config/android/internal_rules.gni
[modify] https://crrev.com/8e50b8d5a4d8523abba6780a44c4d5716824f681/build/config/android/rules.gni

Comment 22 by estevenson@chromium.org, Aug 15 2017

Cc: estevenson@chromium.org

Comment 23 by ranj@chromium.org, Oct 19 2017 

I think the function is ready but we haven't enabled it in production.
Any plan for the follow up?
Project Member

Comment 24 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b4d22ba3d49e1e3441aab55df12d81a9660486e

commit 6b4d22ba3d49e1e3441aab55df12d81a9660486e
Author: Ran Ji <ranj@chromium.org>
Date: Wed Nov 08 04:41:58 2017

Add build arg "report_java_assert" to report java assert failure

If this arg is set to true, Chrome will report java assertion
failures (without crashing).

Bug:  672945 
Change-Id: I671ad4a3ef3a66d3a50005552aeb2a37f56fef22
Reviewed-on: https://chromium-review.googlesource.com/734236
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Ran Ji <ranj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514740}
[modify] https://crrev.com/6b4d22ba3d49e1e3441aab55df12d81a9660486e/build/android/buildhooks/BUILD.gn
[modify] https://crrev.com/6b4d22ba3d49e1e3441aab55df12d81a9660486e/build/android/buildhooks/java/org/chromium/build/BuildHooks.java
[add] https://crrev.com/6b4d22ba3d49e1e3441aab55df12d81a9660486e/build/android/buildhooks/java/templates/BuildHooksConfig.template
[modify] https://crrev.com/6b4d22ba3d49e1e3441aab55df12d81a9660486e/build/config/android/config.gni
[modify] https://crrev.com/6b4d22ba3d49e1e3441aab55df12d81a9660486e/build/config/android/internal_rules.gni
[modify] https://crrev.com/6b4d22ba3d49e1e3441aab55df12d81a9660486e/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

Comment 25 by ranj@chromium.org, Nov 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment