Clients should be embedded in their parents' SurfaceLayer.
Clients should be embedded in their parents' tree via SurfaceLayer so that occlusion and z-order works correctly.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f11613b422d81174773faae3368445018b67b060 commit f11613b422d81174773faae3368445018b67b060 Author: mfomitchev <mfomitchev@chromium.org> Date: Sat Dec 17 00:16:42 2016 ui::Compositor needs a valid FrameSinkId even when it doesn't have ContextFactoryPrivate. BUG= 672943 Review-Url: https://codereview.chromium.org/2582653002 Cr-Commit-Position: refs/heads/master@{#439247} [modify] https://crrev.com/f11613b422d81174773faae3368445018b67b060/ui/compositor/compositor.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a86d0169243b98b51554dcdbad647a24ea782aeb commit a86d0169243b98b51554dcdbad647a24ea782aeb Author: mfomitchev <mfomitchev@chromium.org> Date: Wed Jan 04 22:30:38 2017 Mustash: Ensure surfaces submitted to Mus by WM and embedders contain Surfaces with embeded content. - Use SurfaceLayers in embedders and Window Manager to properly position the embedded content in the layer tree. - WM no longer uses underlay surfaces for window decorations. Instead they are submitted to Mus as part of the WM's surface. - FrameGenerator now only creates SurfaceDrawQuad for the top-level window rather than recursively creating SurfaceDrawQuad for all windows in the window tree, since all surfaces are now part of the tree rooted at the surface of the top-level window. BUG= 672943 , 669964 Review-Url: https://codereview.chromium.org/2580063002 Cr-Commit-Position: refs/heads/master@{#441492} [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/services/ui/ws/display.cc [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/services/ui/ws/display.h [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/services/ui/ws/frame_generator.cc [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/services/ui/ws/frame_generator.h [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/services/ui/ws/frame_generator_delegate.h [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/services/ui/ws/frame_generator_unittest.cc [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/services/ui/ws/platform_display_default.cc [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/services/ui/ws/platform_display_default.h [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/services/ui/ws/platform_display_delegate.h [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/services/ui/ws/server_window_compositor_frame_sink_manager.cc [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/services/ui/ws/server_window_compositor_frame_sink_manager.h [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/services/ui/ws/test_utils.cc [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/services/ui/ws/test_utils.h [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/ui/aura/BUILD.gn [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/ui/aura/mus/DEPS [add] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/ui/aura/mus/client_surface_embedder.cc [add] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/ui/aura/mus/client_surface_embedder.h [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb/ui/aura/mus/window_port_mus.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5040a6ab06d3928b8386e686195badd6b8172682 commit 5040a6ab06d3928b8386e686195badd6b8172682 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Thu Jan 05 00:04:22 2017 Revert of Mustash: Ensure surfaces submitted to Mus by WM and embedders contain Surfaces with embeded content. (patchset #6 id:100001 of https://codereview.chromium.org/2580063002/ ) Reason for revert: This appears to have broken mus ws unittests: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/19757 It's the only mus-related change in the list. Speculatively reverting. Original issue's description: > Mustash: Ensure surfaces submitted to Mus by WM and embedders contain Surfaces with embeded content. > > - Use SurfaceLayers in embedders and Window Manager to properly position the > embedded content in the layer tree. > > - WM no longer uses underlay surfaces for window decorations. Instead they are > submitted to Mus as part of the WM's surface. > > - FrameGenerator now only creates SurfaceDrawQuad for the top-level window > rather than recursively creating SurfaceDrawQuad for all windows in the > window tree, since all surfaces are now part of the tree rooted at the > surface of the top-level window. > > BUG= 672943 , 669964 > > Committed: https://crrev.com/a86d0169243b98b51554dcdbad647a24ea782aeb > Cr-Commit-Position: refs/heads/master@{#441492} TBR=sky@chromium.org,fsamuel@chromium.org,jbauman@chromium.org,mfomitchev@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 672943 , 669964 Review-Url: https://codereview.chromium.org/2617603002 Cr-Commit-Position: refs/heads/master@{#441522} [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/services/ui/ws/display.cc [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/services/ui/ws/display.h [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/services/ui/ws/frame_generator.cc [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/services/ui/ws/frame_generator.h [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/services/ui/ws/frame_generator_delegate.h [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/services/ui/ws/frame_generator_unittest.cc [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/services/ui/ws/platform_display_default.cc [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/services/ui/ws/platform_display_default.h [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/services/ui/ws/platform_display_delegate.h [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/services/ui/ws/server_window_compositor_frame_sink_manager.cc [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/services/ui/ws/server_window_compositor_frame_sink_manager.h [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/services/ui/ws/test_utils.cc [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/services/ui/ws/test_utils.h [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/ui/aura/BUILD.gn [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/ui/aura/mus/DEPS [delete] https://crrev.com/ddc034359eebc9e1f5693e5935933a0798993355/ui/aura/mus/client_surface_embedder.cc [delete] https://crrev.com/ddc034359eebc9e1f5693e5935933a0798993355/ui/aura/mus/client_surface_embedder.h [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/5040a6ab06d3928b8386e686195badd6b8172682/ui/aura/mus/window_port_mus.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2397b79688fd6542405db49e80585ae53bfd4d92 commit 2397b79688fd6542405db49e80585ae53bfd4d92 Author: sadrul <sadrul@chromium.org> Date: Thu Jan 05 21:17:55 2017 Reland of "Mustash: Ensure surfaces submitted to Mus by WM and embedders contain Surfaces with embeded content." - Use SurfaceLayers in embedders and Window Manager to properly position the embedded content in the layer tree. - WM no longer uses underlay surfaces for window decorations. Instead they are submitted to Mus as part of the WM's surface. - FrameGenerator now only creates SurfaceDrawQuad for the top-level window rather than recursively creating SurfaceDrawQuad for all windows in the window tree, since all surfaces are now part of the tree rooted at the surface of the top-level window. Previously landed in crrev.com/441492, but reverted in crrev.com/441522 since it broke some tests on Windows. This CL includes a fix for that brokenness. BUG= 672943 , 669964 TBR=jbauman@ for DEPS change (previously lgtm'ed in the original CL) Review-Url: https://codereview.chromium.org/2613903003 Cr-Commit-Position: refs/heads/master@{#441753} [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/services/ui/ws/display.cc [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/services/ui/ws/display.h [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/services/ui/ws/frame_generator.cc [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/services/ui/ws/frame_generator.h [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/services/ui/ws/frame_generator_delegate.h [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/services/ui/ws/frame_generator_unittest.cc [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/services/ui/ws/platform_display_default.cc [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/services/ui/ws/platform_display_default.h [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/services/ui/ws/platform_display_delegate.h [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/services/ui/ws/server_window_compositor_frame_sink_manager.cc [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/services/ui/ws/server_window_compositor_frame_sink_manager.h [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/services/ui/ws/test_utils.cc [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/services/ui/ws/test_utils.h [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/ui/aura/BUILD.gn [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/ui/aura/mus/DEPS [add] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/ui/aura/mus/client_surface_embedder.cc [add] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/ui/aura/mus/client_surface_embedder.h [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/2397b79688fd6542405db49e80585ae53bfd4d92/ui/aura/mus/window_port_mus.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec78ec0763a819fc5d5f346bef3538ff090368a5 commit ec78ec0763a819fc5d5f346bef3538ff090368a5 Author: fsamuel <fsamuel@chromium.org> Date: Tue Jan 10 20:35:53 2017 Mus: Remove CompositorFrameSinkType Now that underlay surfaces are gone, there is no reason to have a CompositorFrameSinkType in Mus. BUG= 672943 Review-Url: https://codereview.chromium.org/2617403003 Cr-Commit-Position: refs/heads/master@{#442675} [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/content/browser/compositor/mus_browser_compositor_output_surface.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/content/renderer/mus/compositor_mus_connection.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/public/cpp/tests/test_window_tree.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/public/cpp/tests/test_window_tree.h [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/public/cpp/window.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/public/cpp/window.h [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/public/cpp/window_tree_client.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/public/cpp/window_tree_client.h [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/public/interfaces/window_tree.mojom [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/public/interfaces/window_tree_constants.mojom [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/access_policy.h [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/default_access_policy.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/default_access_policy.h [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/frame_generator.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/frame_generator_unittest.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/server_window.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/server_window.h [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/server_window_compositor_frame_sink_manager.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/server_window_compositor_frame_sink_manager.h [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/server_window_compositor_frame_sink_manager_test_api.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/window_finder.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/window_manager_access_policy.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/window_manager_access_policy.h [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/window_server.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/window_server_test_impl.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/window_tree.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/window_tree.h [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/services/ui/ws/window_tree_client_unittest.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/ui/aura/mus/mus_context_factory.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/ui/aura/mus/window_port_mus.h [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/ui/aura/mus/window_tree_client.h [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/ui/aura/test/mus/test_window_tree.cc [modify] https://crrev.com/ec78ec0763a819fc5d5f346bef3538ff090368a5/ui/aura/test/mus/test_window_tree.h
As described here, this bug is FIXED. Closing.
Issue 655716 has been merged into this issue.
Comment 1 by fsam...@chromium.org
, Dec 9 2016