presubmit errors about testserver.pydeps NOT touched by CL |
||
Issue description
When I tried to upload a CL (git cl upload), I got this error:
$ git cl upload
Using 50% similarity for rename/copy detection. Override with --similarity.
Running presubmit upload checks ...
** Presubmit ERRORS **
File is stale: net/tools/testserver/testserver.pydeps
Diff (apply to fix):
***
---
***************
*** 52,61 ****
../../../third_party/tlslite/tlslite/utils/compat.py
../../../third_party/tlslite/tlslite/utils/cryptomath.py
../../../third_party/tlslite/tlslite/utils/keyfactory.py
- ../../../third_party/tlslite/tlslite/utils/openssl_aes.py
- ../../../third_party/tlslite/tlslite/utils/openssl_rc4.py
- ../../../third_party/tlslite/tlslite/utils/openssl_rsakey.py
- ../../../third_party/tlslite/tlslite/utils/openssl_tripledes.py
../../../third_party/tlslite/tlslite/utils/p256.py
../../../third_party/tlslite/tlslite/utils/pem.py
../../../third_party/tlslite/tlslite/utils/pycrypto_aes.py
--- 52,57 ----
To regenerate, run:
build/print_python_deps.py --root net/tools/testserver --output net/tools/testserver/testserver.pydeps net/tools/testserver/testserver.py
Presubmit checks took 11.8s to calculate.
--------------------
My CL does not touch that file at all. The snapshot at cs.chromium.org does have the three lines that are suggested to be dropped. So, I have little idea why I get that error.
,
Jan 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e8beab6c0537dc462b96204491ef96e66628881 commit 0e8beab6c0537dc462b96204491ef96e66628881 Author: martijn <martijn@martijnc.be> Date: Mon Jan 09 21:07:10 2017 Update testserver deps. BUG= 672933 Review-Url: https://codereview.chromium.org/2614623005 Cr-Commit-Position: refs/heads/master@{#442342} [modify] https://crrev.com/0e8beab6c0537dc462b96204491ef96e66628881/net/tools/testserver/testserver.pydeps
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35daf976f75515e7679affea5c30c0e1a9dd6108 commit 35daf976f75515e7679affea5c30c0e1a9dd6108 Author: zpeng <zpeng@chromium.org> Date: Wed Jan 11 17:55:12 2017 Fix conditional deps in net/tools/testserver/testserver.pydeps BUG= 672933 Review-Url: https://codereview.chromium.org/2626933003 Cr-Commit-Position: refs/heads/master@{#442951} [modify] https://crrev.com/35daf976f75515e7679affea5c30c0e1a9dd6108/net/tools/testserver/testserver.pydeps
,
Jan 11 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by tsniatow...@opera.com
, Dec 13 2016