Use aura-mus in Chrome browser in Mus+ash
I've actually started this (should have filed a bug).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89636c392949e162b3be339c2273f8d0022819b9 commit 89636c392949e162b3be339c2273f8d0022819b9 Author: sky <sky@chromium.org> Date: Tue Dec 13 03:24:33 2016 Adds ability to specify how aura::Env is created in content aura::Env::CreateInstance() takes a type. This patch plumbs the type through to content::MainFunctionParams and Content::ConteintMainParams so that consumers can specify how they want Env configured. BUG= 672932 TEST=none R=jam@chromium.org Review-Url: https://codereview.chromium.org/2567113002 Cr-Commit-Position: refs/heads/master@{#438023} [modify] https://crrev.com/89636c392949e162b3be339c2273f8d0022819b9/content/app/content_main_runner.cc [modify] https://crrev.com/89636c392949e162b3be339c2273f8d0022819b9/content/browser/browser_main_loop.cc [modify] https://crrev.com/89636c392949e162b3be339c2273f8d0022819b9/content/public/app/BUILD.gn [modify] https://crrev.com/89636c392949e162b3be339c2273f8d0022819b9/content/public/app/content_main.h [modify] https://crrev.com/89636c392949e162b3be339c2273f8d0022819b9/content/public/common/BUILD.gn [modify] https://crrev.com/89636c392949e162b3be339c2273f8d0022819b9/content/public/common/main_function_params.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdbdbcbefd86d1815afa3104fb8be806809a6ddc commit bdbdbcbefd86d1815afa3104fb8be806809a6ddc Author: sky <sky@chromium.org> Date: Tue Dec 13 03:40:20 2016 Fix initialization in MusBrowserCompositorOutputSurface Wasn't nulling out a couple of fields. BUG= 672932 TEST=none R=fsamuel@chromium.org, jbauman@chromium.org Review-Url: https://codereview.chromium.org/2570603002 Cr-Commit-Position: refs/heads/master@{#438035} [modify] https://crrev.com/bdbdbcbefd86d1815afa3104fb8be806809a6ddc/content/browser/compositor/OWNERS [modify] https://crrev.com/bdbdbcbefd86d1815afa3104fb8be806809a6ddc/content/browser/compositor/mus_browser_compositor_output_surface.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ed2f8511467a6010f1319ec211149aa4c7d1ee4 commit 3ed2f8511467a6010f1319ec211149aa4c7d1ee4 Author: sky <sky@chromium.org> Date: Thu Dec 15 01:21:58 2016 Changes DesktopNativeWidgetAura to not call InitHost or window->Show() DesktopWindowTreeHostMus needs WindowTreeHost::window() to only be shown when Show is called. This is important as the visibility of window() is mirrored in the server. To enable that this patch moves the responsibility of calling InitHost() and Show from DesktopNativeWidgetAura to DesktopWindowTreeHost. InitHost() must be called before Show(), hence the need to move InitHost in addition to Show(). BUG= 672932 TEST=covered by tests R=erg@chromium.org Review-Url: https://codereview.chromium.org/2575243002 Cr-Commit-Position: refs/heads/master@{#438701} [modify] https://crrev.com/3ed2f8511467a6010f1319ec211149aa4c7d1ee4/ui/views/mus/BUILD.gn [modify] https://crrev.com/3ed2f8511467a6010f1319ec211149aa4c7d1ee4/ui/views/mus/desktop_window_tree_host_mus.cc [add] https://crrev.com/3ed2f8511467a6010f1319ec211149aa4c7d1ee4/ui/views/mus/desktop_window_tree_host_mus_unittest.cc [modify] https://crrev.com/3ed2f8511467a6010f1319ec211149aa4c7d1ee4/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [modify] https://crrev.com/3ed2f8511467a6010f1319ec211149aa4c7d1ee4/ui/views/widget/desktop_aura/desktop_window_tree_host.h [modify] https://crrev.com/3ed2f8511467a6010f1319ec211149aa4c7d1ee4/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc [modify] https://crrev.com/3ed2f8511467a6010f1319ec211149aa4c7d1ee4/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381 commit e3e1ea3c0699e70c8ca5a6a790641c58be4e1381 Author: sky <sky@chromium.org> Date: Fri Dec 16 06:17:39 2016 Converts chrome to aura-mus aura-mus has a different environment than mus, so WMHelperMus (in exo) was updated accordingly. This breaks switches::kUseMusInRenderer. I'll fix that next. BUG= 672932 663525 TEST=covered by tests R=reveman@chromium.org, sadrul@chromium.org Review-Url: https://codereview.chromium.org/2578893003 Cr-Commit-Position: refs/heads/master@{#439044} [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/app/DEPS [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/app/chrome_main.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/ash/launcher/settings_window_observer.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/ash/launcher/settings_window_observer.h [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/views/frame/browser_frame_mus.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/views/frame/browser_frame_mus.h [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.h [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/views/frame/immersive_context_mus.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/views/frame/immersive_context_mus.h [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/views/status_bubble_views.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/browser/ui/views/tabs/window_finder_mus.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/chrome/test/base/mash_browser_tests_main.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/components/exo/BUILD.gn [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/components/exo/DEPS [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/components/exo/wm_helper_mus.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/components/exo/wm_helper_mus.h [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/services/ui/ws/window_tree.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/ui/aura/mus/focus_synchronizer.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/ui/aura/mus/focus_synchronizer.h [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/ui/views/mus/desktop_window_tree_host_mus.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/ui/views/mus/mus_client.cc [modify] https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381/ui/views/mus/mus_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c07fea5aea5871cf1ce00260451486a19959b77c commit c07fea5aea5871cf1ce00260451486a19959b77c Author: ksakamoto <ksakamoto@chromium.org> Date: Fri Dec 16 08:00:59 2016 Revert of Converts chrome to aura-mus (patchset #4 id:60001 of https://codereview.chromium.org/2578893003/ ) Reason for revert: Broke Linux ChromiumOS Builder (dbg) build. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/81640 Original issue's description: > Converts chrome to aura-mus > > aura-mus has a different environment than mus, so WMHelperMus (in exo) > was updated accordingly. > > This breaks switches::kUseMusInRenderer. I'll fix that next. > > BUG= 672932 663525 > TEST=covered by tests > R=reveman@chromium.org, sadrul@chromium.org > > Committed: https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381 > Cr-Commit-Position: refs/heads/master@{#439044} TBR=reveman@chromium.org,sadrul@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 672932 663525 Review-Url: https://codereview.chromium.org/2577963006 Cr-Commit-Position: refs/heads/master@{#439063} [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/app/DEPS [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/app/chrome_main.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/ash/launcher/settings_window_observer.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/ash/launcher/settings_window_observer.h [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/views/frame/browser_frame_mus.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/views/frame/browser_frame_mus.h [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.h [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/views/frame/immersive_context_mus.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/views/frame/immersive_context_mus.h [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/views/status_bubble_views.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/browser/ui/views/tabs/window_finder_mus.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/chrome/test/base/mash_browser_tests_main.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/components/exo/BUILD.gn [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/components/exo/DEPS [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/components/exo/wm_helper_mus.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/components/exo/wm_helper_mus.h [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/services/ui/ws/window_tree.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/ui/aura/mus/focus_synchronizer.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/ui/aura/mus/focus_synchronizer.h [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/ui/views/mus/desktop_window_tree_host_mus.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/ui/views/mus/mus_client.cc [modify] https://crrev.com/c07fea5aea5871cf1ce00260451486a19959b77c/ui/views/mus/mus_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cea631eaeaa21f4a0865cbb2d6f6a51535509681 commit cea631eaeaa21f4a0865cbb2d6f6a51535509681 Author: sky <sky@chromium.org> Date: Fri Dec 16 21:52:22 2016 Converts chrome to aura-mus aura-mus has a different environment than mus, so WMHelperMus (in exo) was updated accordingly. This breaks switches::kUseMusInRenderer. I'll fix that next. BUG= 672932 663525 TEST=covered by tests R=reveman@chromium.org, sadrul@chromium.org Committed: https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381 Review-Url: https://codereview.chromium.org/2578893003 Cr-Original-Commit-Position: refs/heads/master@{#439044} Cr-Commit-Position: refs/heads/master@{#439201} [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/app/DEPS [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/app/chrome_main.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/ash/launcher/settings_window_observer.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/ash/launcher/settings_window_observer.h [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/views/frame/browser_frame_mus.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/views/frame/browser_frame_mus.h [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.h [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/views/frame/immersive_context_mus.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/views/frame/immersive_context_mus.h [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/views/status_bubble_views.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/browser/ui/views/tabs/window_finder_mus.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/chrome/test/base/mash_browser_tests_main.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/components/exo/BUILD.gn [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/components/exo/DEPS [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/components/exo/wm_helper_mus.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/components/exo/wm_helper_mus.h [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/services/ui/ws/window_tree.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/ui/aura/mus/focus_synchronizer.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/ui/aura/mus/focus_synchronizer.h [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/ui/views/mus/desktop_window_tree_host_mus.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/ui/views/mus/mus_client.cc [modify] https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681/ui/views/mus/mus_client.h
The browser now uses aura-mus. The renderer uses mus directly and needs to be converted. That's filed here: 672913.
Comment 1 by sky@chromium.org
, Dec 9 2016Owner: sky@chromium.org
Status: Started (was: Untriaged)