New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672918 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
cwp



Sign in to add a comment

quipper: Serialize/deserialize read info

Project Member Reported by sque@chromium.org, Dec 9 2016

Issue description

Read info fields in sample info is being read by PerfReader but not serialized by PerfSerializer.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/770ed88d8c2bf1ac536126af9456acb018bf6ad3

commit 770ed88d8c2bf1ac536126af9456acb018bf6ad3
Author: Simon Que <sque@google.com>
Date: Sat Dec 03 02:33:40 2016

quipper: Add read data in sample info to PerfDataProto

See "struct sample_read" in kernel/perf_internals.h for the
corresponding perf data definition.

BUG= chromium:672918 
TEST=build successfully

Change-Id: I1743d4bfb26d76d0ad94098fd115dcbfeef9f3c0
Reviewed-on: https://chromium-review.googlesource.com/418402
Commit-Ready: Simon Que <sque@chromium.org>
Tested-by: Simon Que <sque@chromium.org>
Reviewed-by: Gabriel Marin <gmx@chromium.org>

[modify] https://crrev.com/770ed88d8c2bf1ac536126af9456acb018bf6ad3/chromiumos-wide-profiling/perf_data.proto

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/21f681f2e5bf3270f086b0b3dc2d746b6283dfde

commit 21f681f2e5bf3270f086b0b3dc2d746b6283dfde
Author: Simon Que <sque@google.com>
Date: Tue Dec 13 22:34:17 2016

quipper: Add PerfReaderTest for sample info fields

There is currently no comprehensive unit test for handling all the
sample info fields in a sample event. By adding this test, we provide a
place for additional fields to be tested in the future when quipper
needs to support them.

BUG= chromium:672918 
TEST=unit tests pass

Change-Id: I8a8f4320dfc11f8b140b6078dc6f0444e69ee09a
Reviewed-on: https://chromium-review.googlesource.com/419699
Commit-Ready: Simon Que <sque@chromium.org>
Tested-by: Simon Que <sque@chromium.org>
Reviewed-by: Chong Jiang <chongjiang@chromium.org>

[modify] https://crrev.com/21f681f2e5bf3270f086b0b3dc2d746b6283dfde/chromiumos-wide-profiling/perf_reader_test.cc

Comment 4 by sque@chromium.org, Dec 20 2016

Status: Fixed (was: Started)

Comment 5 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 6 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment