New issue
Advanced search Search tips

Issue 672917 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Nov 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Reenable flaky NetworkQualityEstimator tests on ios-simulator

Project Member Reported by tbansal@chromium.org, Dec 9 2016 
NetworkQualityEstimatorTest.TestEffectiveConnectionTypeObserver was disabled because it was flaky on ios-simulator.

https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/118840

NetworkQualityEstimatorTest.TestEffectiveConnectionTypeObserver: 
../../net/nqe/network_quality_estimator_unittest.cc:1401: Failure
Value of: observer.effective_connection_types().size()
  Actual: 0
Expected: 1U
Which is: 1
../../base/test/histogram_tester.cc:158: Failure
Value of: actual_count
  Actual: 0
Expected: expected_count
Which is: 1
Histogram "NQE.MainFrame.EffectiveConnectionType" does not have the right number of samples (1) in the expected bucket (3). It has (0).
../../base/test/histogram_tester.cc:174: Failure
Value of: actual_count
  Actual: 0
Expected: expected_count
Which is: 1
Histogram "NQE.MainFrame.EffectiveConnectionType" does not have the right total number of samples (1). It has (0).
../../base/test/histogram_tester.cc:158: Failure
Value of: actual_count
  Actual: 0
Expected: expected_count
Which is: 1
Histogram "NQE.MainFrame.EffectiveConnectionType.Unknown" does not have the right number of samples (1) in the expected bucket (3). It has (0).
../../base/test/histogram_tester.cc:174: Failure
Value of: actual_count
  Actual: 0
Expected: expected_count
Which is: 1
Histogram "NQE.MainFrame.EffectiveConnectionType.Unknown" does not have the right total number of samples (1). It has (0).
../../net/nqe/network_quality_estimator_unittest.cc:1415: Failure
Value of: observer.effective_connection_types().size()
  Actual: 0
Expected: 1U
Which is: 1
../../net/nqe/network_quality_estimator_unittest.cc:1422: Failure
Value of: observer.effective_connection_types().size()
  Actual: 1
Expected: 2U
Which is: 2
../../net/nqe/network_quality_estimator_unittest.cc:1429: Failure
Value of: observer.effective_connection_types().size()
  Actual: 1
Expected: 2U
Which is: 2

Comment 1 by tbansal@chromium.org, Dec 12 2016

Summary: Reenable flaky NetworkQualityEstimator tests on ios-simulator (was: Reenable NetworkQualityEstimatorTest.TestEffectiveConnectionTypeObserver on ios-simulator)
ObtainThresholdsOnlyTransportRTT is also flaky:

NetworkQualityEstimatorTest.ObtainThresholdsOnlyTransportRTT: 
../../net/nqe/network_quality_estimator_unittest.cc:887: Failure
Value of: estimator.GetEffectiveConnectionType()
  Actual: 0
Expected: test.expected_conn_type
Which is: 1
../../net/nqe/network_quality_estimator_unittest.cc:887: Failure
Value of: estimator.GetEffectiveConnectionType()
  Actual: 0
Expected: test.expected_conn_type
Which is: 1
../../net/nqe/network_quality_estimator_unittest.cc:887: Failure
Value of: estimator.GetEffectiveConnectionType()
  Actual: 0
Expected: test.expected_conn_type
Which is: 2
../../net/nqe/network_quality_estimator_unittest.cc:887: Failure
Value of: estimator.GetEffectiveConnectionType()
  Actual: 0
Expected: test.expected_conn_type
Which is: 2
../../net/nqe/network_quality_estimator_unittest.cc:887: Failure
Value of: estimator.GetEffectiveConnectionType()
  Actual: 0
Expected: test.expected_conn_type
Which is: 3
../../net/nqe/network_quality_estimator_unittest.cc:887: Failure
Value of: estimator.GetEffectiveConnectionType()
  Actual: 0
Expected: test.expected_conn_type
Which is: 3
../../net/nqe/network_quality_estimator_unittest.cc:887: Failure
Value of: estimator.GetEffectiveConnectionType()
  Actual: 0
Expected: test.expected_conn_type
Which is: 4
../../net/nqe/network_quality_estimator_unittest.cc:887: Failure
Value of: estimator.GetEffectiveConnectionType()
  Actual: 0
Expected: test.expected_conn_type
Which is: 4
../../net/nqe/network_quality_estimator_unittest.cc:887: Failure
Value of: estimator.GetEffectiveConnectionType()
  Actual: 0
Expected: test.expected_conn_type
Which is: 5
../../net/nqe/network_quality_estimator_unittest.cc:887: Failure
Value of: estimator.GetEffectiveConnectionType()
  Actual: 0
Expected: test.expected_conn_type
Which is: 5
../../net/nqe/network_quality_estimator_unittest.cc:887: Failure
Value of: estimator.GetEffectiveConnectionType()
  Actual: 0
Expected: test.expected_conn_type
Which is: 5
../../net/nqe/network_quality_estimator_unittest.cc:887: Failure
Value of: estimator.GetEffectiveConnectionType()
  Actual: 0
Expected: test.expected_conn_type
Which is: 5
../../net/nqe/network_quality_estimator_unittest.cc:887: Failure
Value of: estimator.GetEffectiveConnectionType()
  Actual: 0
Expected: test.expected_conn_type
Which is: 5

Comment 2 by tbansal@chromium.org, Dec 12 2016

Labels: NQE

Comment 3 by tbansal@chromium.org, Feb 13 2017

Components: Internals>Network>NetworkQuality

Comment 4 by tbansal@chromium.org, Feb 14 2017

Labels: -nqe

Comment 5 by tbansal@chromium.org, Mar 23 2017

Components: -Internals>Network

Comment 6 by tbansal@chromium.org, May 10 2017

Owner: ----
Status: Available (was: Assigned)

Comment 7 by bengr@chromium.org, Nov 29 2017 

Refreshed during triage.

Comment 8 by tbansal@chromium.org, Nov 29 2017

Labels: OS-iOS
Status: WontFix (was: Available)
We can reopen this if NQE is ever enabled on ios in future.
►

Sign in to add a comment