xf86-videwo-armsoc: Failed to build with glibc 2.23 |
||||
Issue description
When building xf86-videwo-armsoc with glibc 2.23, we got
In file included from /usr/include/string.h:634:0,
from /usr/include/xorg/os.h:53,
from /usr/include/xorg/misc.h:115,
from /usr/include/xorg/xf86str.h:37,
from /usr/include/xorg/xf86.h:44,
from armsoc_dumb.c:30:
/usr/include/xorg/os.h:579:1: error: expected identifier or ‘(’ before ‘__extension__’
strndup(const char *str, size_t n);
,
Dec 10 2016
Why are we building xf86-video-armsoc? By now I believe that all boards that would use this driver have been converted to freon, and therefore would not need X.org video drivers.
,
Dec 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/xf86-video-armsoc/+/1324c420aab940e3932d7960e13af6601d336733 commit 1324c420aab940e3932d7960e13af6601d336733 Author: Yunlian Jiang <yunlian@google.com> Date: Fri Dec 09 18:42:51 2016 xf86-video-armsoc: pick up an upstream patch. This CL picks the upstream patch. commit 47a1f4639c010e63249c794ea600dc5555e061ac Author: Derek Stavis <dekestavis@gmail.com> Date: Sun May 10 10:37:33 2015 -0300 Include xorg-server.h to fix build errors on newest glibc BUG= chromium:672915 TEST=xf86-video-armsoc builds with glibc 2.23. Change-Id: I341198458422c38527128b7e9d0a7e15a79b7abf Reviewed-on: https://chromium-review.googlesource.com/418698 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org> [modify] https://crrev.com/1324c420aab940e3932d7960e13af6601d336733/src/omap_dumb.c [modify] https://crrev.com/1324c420aab940e3932d7960e13af6601d336733/src/bo_rockchip.c
,
Dec 12 2016
yeah we don't need armsoc. Which board builds it?
,
Dec 12 2016
In the log, it says veyron_jaq. But for veyron_jaq-release build, I could not find armsoc. Anyway, I will mark this as fixed.
,
Jan 13 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by yunlian@chromium.org
, Dec 9 2016