Issue metadata
Sign in to add a comment
|
window.matchMedia('(pointer:coarse)').matches returns false on latest Chrome
Reported by
der...@gmail.com,
Dec 9 2016
|
||||||||||||||||||||||
Issue description
Chrome Version : 55.0.2883.84
OS Version:
URLs (if applicable) :
Other browsers tested:
Chrome Android 54.0.2840.85: OK
What steps will reproduce the problem?
1. Connect remotely to device using Developer Tools
2. In console, type: window.matchMedia('(pointer:coarse)').matches
3.
What is the expected result?
The return valued should be true.
What happens instead of that?
The return value is false.
UserAgentString: Mozilla/5.0 (Linux; Android 7.1.1; Pixel XL Build/NMF26O) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.84 Mobile Safari/537.36
,
Dec 14 2016
,
Dec 15 2016
More convenient repro: Open https://jsbin.com/dayekoxoqu/edit?console on device. Confirmed, Chrome Android v54 returns true; v55 returns false
,
Dec 15 2016
+Navid, please triage.
,
Dec 16 2016
Issue 674873 has been merged into this issue.
,
Dec 16 2016
Here is an easier repro: http://mustaqahmed.github.io/web/mq-test.html There is only one change in touch_device_android.cc change between 54.0.2840.85 (known good revision) and 55.0.2883.84 (known bad revision): https://chromium.googlesource.com/chromium/src/+/4cef7d0449592119bc8bdee2b5a98c89543f4c03 tobiasjs@: could you please look into this?
,
Dec 16 2016
It's unfortunate that this regression made it to stable without us noticing! Are we missing some test coverage? Tobias, any other lessons to be learned? Let's try to get a fix into M56. This is almost certainly subtly breaking some websites (see dupe bugs).
,
Dec 16 2016
,
Dec 16 2016
Re testing: there seems to be a single test (fast/media/mq-pointer.html) that only checks setters/getters. We need platform-specific expectations here at the very least. I will file a separate bug for it.
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1c093ed77175994ae746c380d331961aa755955 commit d1c093ed77175994ae746c380d331961aa755955 Author: tobiasjs <tobiasjs@chromium.org> Date: Tue Dec 20 17:25:05 2016 Revert TouchDevice.hasAnySource optimization. Android InputDevice sources are not represented by single set bits, and so or'ing them together is not correct. BUG= 672907 Review-Url: https://codereview.chromium.org/2594733002 Cr-Commit-Position: refs/heads/master@{#439834} [modify] https://crrev.com/d1c093ed77175994ae746c380d331961aa755955/ui/android/java/src/org/chromium/ui/base/TouchDevice.java
,
Dec 20 2016
,
Dec 20 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 26 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 29 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c379ecf81d253ca191ca39e1639b5a3380aaf6a5 commit c379ecf81d253ca191ca39e1639b5a3380aaf6a5 Author: Tobias Sargeant <tobiasjs@google.com> Date: Sun Jan 01 20:12:04 2017 Revert TouchDevice.hasAnySource optimization. Android InputDevice sources are not represented by single set bits, and so or'ing them together is not correct. BUG= 672907 Review-Url: https://codereview.chromium.org/2594733002 Cr-Commit-Position: refs/heads/master@{#439834} (cherry picked from commit d1c093ed77175994ae746c380d331961aa755955) Review-Url: https://codereview.chromium.org/2604353002 . Cr-Commit-Position: refs/branch-heads/2924@{#638} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/c379ecf81d253ca191ca39e1639b5a3380aaf6a5/ui/android/java/src/org/chromium/ui/base/TouchDevice.java
,
Jan 3 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ajha@chromium.org
, Dec 12 2016