Issue metadata
Sign in to add a comment
|
Alt+Shift obsolete-accelerator notification is shown when trying to send feedback |
||||||||||||||||||||||
Issue descriptionGoogle Chrome 54.0.2840.101 (Official Build) (64-bit) Platform 8743.85.0 (Official Build) stable-channel peppy 1. Hit Alt+Shift+i to try to send a feedback report because something is broken. 2. Get yelled at by a notification for trying to use Alt+Shift to switch input methods. :-( Luckily, we don't actually switch input methods here; we just display the notification. I *think* that this happens whenever I release either Alt or Shift before the feedback window appears and receives the focus. If I release 'i' immediately but only release Alt and/or Shift after the feedback window is focused, I usually don't get the notification. The code that displays this notification should avoid displaying it if another key was pressed while the modifiers were held.
,
Dec 20 2016
+tbuckley, when do we plan to turn off the notification for the deprecated Alt+Shift NEXT_IME shortcut? It has been disabled since M53.
,
Jan 5 2017
Friendly ping.
,
Jan 26 2017
Discussed with abodenha@ and agreed to remove the notification in M58.
,
Jan 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd98638fcb71657f577d763ae2099f30be6df7d7 commit bd98638fcb71657f577d763ae2099f30be6df7d7 Author: afakhry <afakhry@chromium.org> Date: Mon Jan 30 18:06:58 2017 Remove the deprecated Alt+Shift shortcut completely The Alt+shift showtcut was disabled in M53, but since then we kept its deprecation notification. Now it's time to remove it entirely in M58. BUG= 672905 TEST=manually, Alt+Shift should still do nothing, and should show no notification. Review-Url: https://codereview.chromium.org/2658853003 Cr-Commit-Position: refs/heads/master@{#447013} [modify] https://crrev.com/bd98638fcb71657f577d763ae2099f30be6df7d7/ash/ash_chromeos_strings.grdp [modify] https://crrev.com/bd98638fcb71657f577d763ae2099f30be6df7d7/ash/common/accelerators/accelerator_controller.cc [modify] https://crrev.com/bd98638fcb71657f577d763ae2099f30be6df7d7/ash/common/accelerators/accelerator_controller.h [modify] https://crrev.com/bd98638fcb71657f577d763ae2099f30be6df7d7/ash/common/accelerators/accelerator_table.cc [modify] https://crrev.com/bd98638fcb71657f577d763ae2099f30be6df7d7/tools/metrics/histograms/histograms.xml
,
Jan 30 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by omrilio@chromium.org
, Dec 20 2016