New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 672896 link

Starred by 1 user
Status: WontFix
Owner:
█ lawrencewu@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
bcwh...@chromium.org
asvitk...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make FieldTrial::State also include params

Reported by lawrencewu@chromium.org, Dec 9 2016 
Now that we can have experiment parameters, we need to extend FieldTrial::State to also include them, so we can get them in GetAllFieldTrialsFromPersistentAllocator.

Comment 1 by asvitk...@chromium.org, Dec 9 2016

Cc: bcwh...@chromium.org
Hmm, I wonder if it wouldn't be better to expose access to FieldTrialEntry directly for breadcrumbs? Ideally we could just re-use the same data format as we use for shared memory - so we don't need a new format.

Comment 2 by lawrencewu@chromium.org, Dec 9 2016 

That sounds fine too -- bcwhite@, what do you think?

Comment 3 by bcwh...@chromium.org, Dec 9 2016 

That works.  For our use, it would just be pointers to objects with GetTrialAndGroupName() and GetParams() methods.

Comment 4 by lawrencewu@chromium.org, Dec 9 2016

Status: WontFix (was: Assigned)
OK cool. Closing this then.
►

Sign in to add a comment