New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672887 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 625646



Sign in to add a comment

PushMessagingService attempts to register a subscription during shutdown

Project Member Reported by dgn@chromium.org, Dec 9 2016

Issue description

https://crash.corp.google.com/browse?reportid=c19bf85880000000

BrowserProcessImpl::Pin()
KeepAliveRegistry::OnKeepAliveStateChanged(bool)
ScopedKeepAlive::ScopedKeepAlive(KeepAliveOrigin,KeepAliveRestartOption)
BackgroundModeManager::UpdateKeepAliveAndTrayIcon()
BackgroundModeManager::StartBackgroundMode()
BackgroundModeManager::OnClientsChanged([...])
BackgroundModeManager::RegisterTrigger(Profile *,BackgroundTrigger *,bool)
PushMessagingServiceImpl::IncreasePushSubscriptionCount(int,bool)
PushMessagingServiceImpl::DidSubscribeWithEncryptionInfo([...])
[...]
gcm::GCMEncryptionProvider::DidCreateEncryptionInfo([...])
[...]
gcm::GCMKeyStore::DidStoreKeys(gcm::KeyPair const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::Callback<void ,1,1> const &,bool)
[...]
base::MessageLoop::RunTask(base::PendingTask *)
[...]
ChromeBrowserMainParts::MainMessageLoopRun(int *)


I suppose the BackgroundModeManager could skip the trigger registration if we are shutting down, but it might be better for the message to be entirely skipped in the first place.
 

Comment 1 by peter@chromium.org, Dec 13 2016

Cc: joh...@chromium.org
Components: Blink>PushAPI

Sign in to add a comment