+rpop@

I wonder if we should switch to Ctrl-Tab and Ctrl-Shift-Tab as the hotkeys shown in the menu (seems like we also support these.) This would be more consistent with both Windows/Linux Chrome and Safari.

My concern with making the Command-Option-arrow hotkeys follow the arrow is that they're called "Next tab" and "Previous tab", so you're violating one expectation or another either way.

What if we made the arrow commands visually consistent, and made their names consistent with RTL as well? "Next tab" should be the left direction, and "Previous" the right direction.

It seems to be a convention to show cmd shortcuts in Mac menus, rather than the cross-platform consistent ones. 

Uploaded Safari screenshot for reference.

Re: switching the key command names, I'm curious if changing key command semantics based on directionality is idiomatic. Unfortunately the HIG is no help.

Deleted: Screen Shot 2016-12-12 at 10.15.06 AM.png 10.6 KB

	Screen Shot 2016-12-12 at 10.15.06 AM.png 10.6 KB View Download

Thanks for sharing that. In that case, showing the ctrl shortcuts is fine with me.

Would we need to go through any kind of UX review to make this change?

We'll include this when we go for UI review of the RTL changes as a whole - this will need to happen before we enable on beta.

Assigning to avi@ for Q1 Mac work.

FYI, command+option+arrow keys are backwards in the same way.

The question that I have re comment 4 is that switching the shortcuts from being arrow based to being tab based wouldn't be RTL-only, so relying on the UX review for RTL mode might not be possible.

I'm researching, and finding lots of interesting things here.

First, in accelerators_cocoa.mm, there are mappings for command+option+arrows that are ignored because they are menu shortcuts, and the menu shortcut matching happens first. However, if you remove the shortcuts from the menu, the mappings in accelerators_cocoa.mm do *not* kick in! They seem to be ignored. Have not figured that one out yet.

Second, there are { } in global_keyboard_shortcuts_cocoa_mac.mm. Those are AFAIK for French and German keyboard layouts, so I'm not worrying about them. Do we need to worry about RTL there?

Third, there is mirror cleanup happening in global_keyboard_shortcuts_mac.mm, where in an RTL system, we un-mirrored [] characters to cope with our LTR-only app. Now that we're adding RTL mode, we might need to take that out. Having an RTL tester is likely going to be  a requirement here.

Ok, let's bring the question there now - let's follow up in email.

Giving back to Leonard.

**UI mass Triage**

Tested the issue on latest chrome canary# 72.0.3622.0 using Mac with steps mentioned below:
1) Launched chrome reported version in RTL mode(able to see tabs from right to left)
2) Opened few tabs and pressed Cmd+[ and cmd+], observed page navigated between current page and previous page instead of switching between the tabs.

Adding appropriate labels to it and let us know if this issue still needs any further action.

 Issue 891244  has been merged into this issue.