[Password Manager] Passwords are not show on chrome://settings/passwords |
|||||
Issue descriptionWhat steps will reproduce the problem? (1) Go to chrome://settings/passwords (2) Type something in the search field so that the list of passwords will empty. (3) Clear the search field. What is the expected result? All passwords should be shown. What happens instead? No passwords are shown.
,
Dec 12 2016
Thanks for finding this kolos@, I will have a look.
,
Dec 12 2016
I think I managed to find the root cause: This bug is triggered when the list of matched passwords transitions from an empty to a non-empty state, within non-empty states the update is correct. For example, if you issue a non-matching query of length at least two, then delete all query characters except the first one, wait for the update, and finally delete the last character you will get the list of all passwords. I will send out a CL shortly that addresses this issue.
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0edd353c07b8cebe483ec64f5e1abe638001d2d4 commit 0edd353c07b8cebe483ec64f5e1abe638001d2d4 Author: jdoerrie <jdoerrie@chromium.org> Date: Wed Dec 21 08:05:41 2016 Fix bug when transitioning from an empty to a non-empty password list This change fixes a bug that occurs when a list transitions from an empty to a non-empty state. Before this change, the entries of the list were updated before its visibility, which causes |List.redraw()| to skip adding items to the viewport when the list was hidden. Now the visibility will be updated first, leading to correct behavior. BUG= 672869 R=dbeam@chromium.org CC=kolos@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2571443002 Cr-Commit-Position: refs/heads/master@{#440048} [modify] https://crrev.com/0edd353c07b8cebe483ec64f5e1abe638001d2d4/chrome/browser/resources/options/password_manager.js
,
Dec 23 2016
,
Dec 23 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d446c28066e5c0e524f0420125207d75da682299 commit d446c28066e5c0e524f0420125207d75da682299 Author: Vaclav Brozek <vabr@chromium.org> Date: Fri Dec 23 10:08:57 2016 Fix bug when transitioning from an empty to a non-empty password list This change fixes a bug that occurs when a list transitions from an empty to a non-empty state. Before this change, the entries of the list were updated before its visibility, which causes |List.redraw()| to skip adding items to the viewport when the list was hidden. Now the visibility will be updated first, leading to correct behavior. BUG= 672869 R=dbeam@chromium.org CC=kolos@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2571443002 Cr-Commit-Position: refs/heads/master@{#440048} (cherry picked from commit 0edd353c07b8cebe483ec64f5e1abe638001d2d4) Review-Url: https://codereview.chromium.org/2604563002 . Cr-Commit-Position: refs/branch-heads/2924@{#610} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/d446c28066e5c0e524f0420125207d75da682299/chrome/browser/resources/options/password_manager.js
,
Dec 23 2016
I checked that the merge in #7 kept the betabuilders green.
,
Jan 4 2017
Tested the same on win10 and Linux 14.04 using chrome version 56.0.2924.51 - After step3 passwords displayed fine Please find the screencast Fix works as expected
,
Jan 4 2017
Thank you for the screencast, I am marking this as fixed now. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kolos@chromium.org
, Dec 9 2016Status: Assigned (was: Unconfirmed)