New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672867 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Removed listeners active but not listed after page reload

Reported by moni...@gmail.com, Dec 9 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.98 Safari/537.36

Steps to reproduce the problem:
1. Remove an event listener for an element
2. Reload the page
3. Try to remove it again

What is the expected behavior?
THe expected behavior is, that - since after a page reload the events are attached again, they should be listed in the Event Listeners panel.

Otherwise, you cannot remove the event that is again active after a page reload.

What went wrong?
The list of listeners should be refreshed after page reload.

Did this work before? N/A 

Chrome version: 54.0.2840.98  Channel: n/a
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 23.0 r0
 
Components: -Blink Platform>DevTools
Labels: M-57
Owner: phulce@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 4 by phulce@chromium.org, Dec 13 2016

Labels: Hotlist-Polish
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c1e09c2062cfd0a37a47837eba5d2654d7a7198

commit 3c1e09c2062cfd0a37a47837eba5d2654d7a7198
Author: phulce <phulce@chromium.org>
Date: Mon Dec 19 20:49:06 2016

DevTools: Fix Elements tab event listener removal

Upon removal of the last event listener of a given type,
the entire tree for that type would be removed from the
DOM and never readded. It's not clear why it was
originally being removed in the first place since the
hidden check will take care of this case already.

Updated the behavior to simply collapse instead of remove.

BUG= 672867 

Review-Url: https://codereview.chromium.org/2574603002
Cr-Commit-Position: refs/heads/master@{#439547}

[modify] https://crrev.com/3c1e09c2062cfd0a37a47837eba5d2654d7a7198/third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js
[modify] https://crrev.com/3c1e09c2062cfd0a37a47837eba5d2654d7a7198/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[add] https://crrev.com/3c1e09c2062cfd0a37a47837eba5d2654d7a7198/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-remove-expected.txt
[add] https://crrev.com/3c1e09c2062cfd0a37a47837eba5d2654d7a7198/third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-remove.html
[modify] https://crrev.com/3c1e09c2062cfd0a37a47837eba5d2654d7a7198/third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js

Comment 6 by phulce@chromium.org, Dec 19 2016

Status: Fixed (was: Started)

Sign in to add a comment