Add ability to get camera facing information to VideoCaptureFactory |
|||
Issue descriptionCurrently, the camera facing information is available in content (on Android) as part of the device name, so to get this information it is necessary to parse the device name. This is ugly and may lead to errors. It would better to expose it as part of media::VideoCaptureFactory or a related API.
,
Jan 24 2017
Note that shenghao@ recently introduced an API for this and added an implementation for ChromeOS andhttps://codereview.chromium.org/2609863004/ Also, there is this hack that works on Android. https://cs.chromium.org/chromium/src/content/public/common/media_stream_request.cc?type=cs&sq=package:chromium&rcl=1485245824&l=41 Can the hack (or a better version) be added for Android?
,
Jan 24 2017
In comment #2 I meant adding the functionality (via hack or otherwise) to the Android version of VideoCaptureDeviceFactory.
,
Jan 25 2018
Sorry, I can't help here. I don't work on non-screen video capture nor do much on Android.
,
Apr 26 2018
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56d9904555ccbe50e265923ab775b6d818d5d046 commit 56d9904555ccbe50e265923ab775b6d818d5d046 Author: Guido Urdaneta <guidou@chromium.org> Date: Thu Apr 26 12:32:52 2018 Remove hack to detect facing mode on Android based on device label. After crrev.com/c/1025213, facing mode is properly supported on Android, so this hack becomes obsolete. Bug: 672856 Change-Id: I7ccdc4f9535074bb7fc1fc2140b441df117ce962 Reviewed-on: https://chromium-review.googlesource.com/1029859 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553992} [modify] https://crrev.com/56d9904555ccbe50e265923ab775b6d818d5d046/content/browser/renderer_host/media/media_devices_dispatcher_host.cc [modify] https://crrev.com/56d9904555ccbe50e265923ab775b6d818d5d046/content/browser/renderer_host/media/media_devices_manager.cc [modify] https://crrev.com/56d9904555ccbe50e265923ab775b6d818d5d046/content/public/common/media_stream_request.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by yini...@chromium.org
, Dec 13 2016Status: Assigned (was: Untriaged)