cannot make ZIP from debug builds
Reported by
pdk...@gmail.com,
Dec 9 2016
|
|||
Issue description
I'm not sure if it does actually affect Debug builds, as I made a Release build with these set.
symbol_level = 2
remove_webcore_debug_symbols = false
And then.
$ chrome/tools/build/linux/make_zip DIR
Traceback (most recent call last):
File "chrome/tools/build/make_zip.py", line 51, in <module>
sys.exit(main(sys.argv[1:]))
File "chrome/tools/build/make_zip.py", line 45, in main
output.write(os.path.join(build_dir, f), f)
File "/usr/lib/python2.7/zipfile.py", line 1141, in write
self._writecheck(zinfo)
File "/usr/lib/python2.7/zipfile.py", line 1106, in _writecheck
raise LargeZipFile("Filesize would require ZIP64 extensions")
zipfile.LargeZipFile: Filesize would require ZIP64 extensions
The fix is simple.
diff --git a/chrome/tools/build/make_zip.py b/chrome/tools/build/make_zip.py
index 81e411e..4694b0c 100755
--- a/chrome/tools/build/make_zip.py
+++ b/chrome/tools/build/make_zip.py
@@ -38,7 +38,7 @@ def main(args):
return 1
with zipfile.ZipFile(output_file, mode = 'w',
- compression = zipfile.ZIP_DEFLATED) as output:
+ compression = zipfile.ZIP_DEFLATED, allowZip64 = True) as output:
for f in files:
sys.stdout.write("%s\r" % f[:40].ljust(40, ' '))
sys.stdout.flush()
Note that the ZIP file is then only about 1GB in size.
,
Dec 16 2016
,
Dec 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e73d181fd4eb9868a26c995079881d07d5819a9 commit 1e73d181fd4eb9868a26c995079881d07d5819a9 Author: skobes <skobes@chromium.org> Date: Fri Dec 16 18:43:09 2016 Fix duplicate name warnings from make_zip, and pass allowZip64. BUG= 672060 , 672851 Review-Url: https://codereview.chromium.org/2585633002 Cr-Commit-Position: refs/heads/master@{#439159} [modify] https://crrev.com/1e73d181fd4eb9868a26c995079881d07d5819a9/chrome/tools/build/make_zip.py
,
Dec 16 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ranjitkan@chromium.org
, Dec 12 2016