Issue metadata
Sign in to add a comment
|
System time on some n5x swarming bots is wildly incorrect |
||||||||||||||||||||||
Issue descriptionI'm not sure if this is intentional or not, but I've tracked down some recent flakes of the Origin Trial token validator tests to an issue with the system clock on some of the n5x swarming devices. See https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82503/steps/content_unittests%20%28with%20patch%29%20on%20Android/logs/TrialTokenValidatorTest.ValidateRequestMultipleHeaders for a recent example. Also see crbug.com/672294 for the original flake report. We're using a dummy token to test the validator, with an expiry timestamp well into the future (2033-ish). This test failed because the device believed the current time to be 2047. I'm going to rewrite the unit tests anyway to mock the time, but if this isn't intentional, then it may be the cause of flakiness elsewhere.
,
Dec 9 2016
I've been trying to land an unrelated trivial patch over the last 24 hours, and it's also failed on n5x swarming. Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android Looks like at least a few bugs were filed against this in the past day.
,
Dec 9 2016
Yeah, the n5x bots have been having some issues: https://crbug.com/672382
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f8aac8277ea14b19c533303288ca1df8d4c8bef commit 6f8aac8277ea14b19c533303288ca1df8d4c8bef Author: iclelland <iclelland@chromium.org> Date: Fri Dec 09 16:08:37 2016 Disable flaky origin trial tests on Android Several tests are flaking on Android swarming bots as they rely on the system time being correct. Disabling them until we can remove the dependency on the system clock. BUG=672294, 672843 TBR=asargent@chromium.org Review-Url: https://codereview.chromium.org/2564873002 Cr-Commit-Position: refs/heads/master@{#437553} [modify] https://crrev.com/6f8aac8277ea14b19c533303288ca1df8d4c8bef/content/common/origin_trials/trial_token_validator_unittest.cc
,
Dec 9 2016
Known issue, not intentional, possibly related.
,
Dec 10 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by serg...@chromium.org
, Dec 9 2016