A CL recently failed the CQ because of a failure on RecentTabsSubMenuModelTest.MaxWidth
which seems unrelated with my change (https://codereview.chromium.org/2549103003)
Failure:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin_chromium_rel_ng%2F345443%2F%2B%2Frecipes%2Fsteps%2Funit_tests__with_patch_%2F0%2Flogs%2FRecentTabsSubMenuModelTest.MaxWidth%2F0
RecentTabsSubMenuModelTest.MaxWidth (run #1):
[ RUN ] RecentTabsSubMenuModelTest.MaxWidth
[1756:3976:1207/052556.768:4270776:ERROR:sessions_sync_manager.cc(232)] No windows present, see crbug.com/639009
Actual: false
Expected: true
Actual: 5
Expected: 6
[1756:3976:1207/052556.780:4270792:FATAL:simple_menu_model.cc(434)] Check failed: static_cast<size_t>(index) < items_.size() (5 vs. 5)
Backtrace:
base::debug::StackTrace::StackTrace [0x03412467+23]
logging::LogMessage::~LogMessage [0x033A5B51+49]
ui::SimpleMenuModel::ValidateItemIndex [0x0361F320+147]
ui::SimpleMenuModel::GetCommandIdAt [0x0361ECB4+14]
RecentTabsSubMenuModel::GetMaxWidthForItemAtIndex [0x03FC265B+11]
RecentTabsSubMenuModelTest_MaxWidth_Test::TestBody [0x0158C0E6+673]
testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x02C2FD94+32]
testing::Test::Run [0x02C36DA8+93]
testing::TestCase::Run [0x02C36E54+133]
testing::internal::UnitTestImpl::RunAllTests [0x02C371D3+433]
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x02C2FDD8+32]
testing::UnitTest::Run [0x02C36FFD+133]
base::TestSuite::Run [0x02A59DA0+95]
base::internal::RunMixin<base::Callback<bool __cdecl(void),1,1> >::Run [0x0508AD13+25]
base::LaunchUnitTests [0x02A5B5E1+77]
main [0x050E569D+176]
__scrt_common_main_seh [0x050AC11F+249] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:253)
BaseThreadInitThunk [0x7519338A+18]
RtlInitializeExceptionChain [0x772D9902+99]
RtlInitializeExceptionChain [0x772D98D5+54]
Comment 1 by tandrii@chromium.org
, Dec 12 2016