New issue
Advanced search Search tips

Issue 672836 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Test Results Server should accept seconds_since_epoch as a float

Project Member Reported by serg...@chromium.org, Dec 9 2016

Issue description

Spec https://www.chromium.org/developers/the-json-test-results-format says that seconds_since_epoch is float, but test-results app defines it as int and fails to accept results which use float. This should be fixed.
 
Status: Started (was: Assigned)
CL: https://chromium-review.googlesource.com/c/418778/
Cc: ehmaldonado@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/9437e263aea4b8b7d335791bf4dc2dd4ec4acf56

commit 9437e263aea4b8b7d335791bf4dc2dd4ec4acf56
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Fri Dec 09 14:38:33 2016

Use float64 instead of int64 for seconds_since_epoch fields

According to the spec, seconds_since_epoch should be float:
https://www.chromium.org/developers/the-json-test-results-format.

BUG= 672836 

Change-Id: Ie2ebf9d84ab8ce78ff92b3c48bd576f09e911ce6
Reviewed-on: https://chromium-review.googlesource.com/418778
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>

[modify] https://crrev.com/9437e263aea4b8b7d335791bf4dc2dd4ec4acf56/go/src/infra/appengine/test-results/frontend/testdata/full_results_0.json
[modify] https://crrev.com/9437e263aea4b8b7d335791bf4dc2dd4ec4acf56/go/src/infra/appengine/test-results/frontend/upload.go
[modify] https://crrev.com/9437e263aea4b8b7d335791bf4dc2dd4ec4acf56/go/src/infra/appengine/test-results/frontend/upload_test.go
[modify] https://crrev.com/9437e263aea4b8b7d335791bf4dc2dd4ec4acf56/go/src/infra/appengine/test-results/model/aggregate_result.go
[modify] https://crrev.com/9437e263aea4b8b7d335791bf4dc2dd4ec4acf56/go/src/infra/appengine/test-results/model/aggregate_result_test.go
[modify] https://crrev.com/9437e263aea4b8b7d335791bf4dc2dd4ec4acf56/go/src/infra/appengine/test-results/model/end_to_end_test.go
[modify] https://crrev.com/9437e263aea4b8b7d335791bf4dc2dd4ec4acf56/go/src/infra/appengine/test-results/model/full_result.go
[modify] https://crrev.com/9437e263aea4b8b7d335791bf4dc2dd4ec4acf56/go/src/infra/appengine/test-results/model/full_result_test.go
[modify] https://crrev.com/9437e263aea4b8b7d335791bf4dc2dd4ec4acf56/go/src/infra/appengine/test-results/model/testdata/full_results.jsonp

Labels: -Pri-3 Pri-2
Status: Fixed (was: Started)
Deployed this to prod.
Cc: estaab@chromium.org zhangtiff@chromium.org
 Issue 672830  has been merged into this issue.

Sign in to add a comment