New issue
Advanced search Search tips

Issue 672813 link

Starred by 4 users
Status: Available
Owner: ----
Cc:
grt@chromium.org
wfh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Investigate COULD_NOT_CREATE_PROCESS errors from mini_installer.

Project Member Reported by grt@chromium.org, Dec 9 2016 
COULD_NOT_CREATE_PROCESS means that setup.exe couldn't be run, either to patch itself or to do the actual install. We have a steady population for whom this is a recurring error. The most popular Windows last error codes are:

ERROR_ACCESS_DENIED
ERROR_FILE_NOT_FOUND
ERROR_SUCCESS (!)
ERROR_PATH_NOT_FOUND
ERROR_FILE_CORRUPT
ERROR_ELEVATION_REQUIRED (user-level only)
ERROR_INVALID_PARAMETER

We should investigate whether some of these are caused by edge cases we could be handling better, or if a repair step is needed. One interesting analysis is to see if COULD_NOT_CREATE_PROCESS is only coming from old clients, or if these clients eventually pick up an update.

Comment 1 by grt@chromium.org, Jun 22 2017

Cc: wfh@chromium.org
In  issue 734899 , we discovered a case of ERROR_FILE_NOT_FOUND due to "TuneUp Utilities 2014" installing itself as a debugger via Image File Execution Options but not being present. I wonder if most/all of these failures are due to similar hijinks.

Will: wdyt of having the mini_installer check for a ...\Image File Execution Options\setup.exe\Debugger when setup.exe can't be run, then deleting the setup.exe key if said Debugger isn't present on disk (or maybe unconditionally deleting it)?

Comment 2 by grt@chromium.org, Jun 22 2017

Cc: grt@chromium.org
 Issue 734899  has been merged into this issue.

Comment 3 by grt@chromium.org, Jun 28 2017 

A better idea would be to randomize the name of the installer. Shouldn't be too hard.

Comment 4 by wfh@chromium.org, Jun 28 2017 

hmm either way you might hit AV/third party issues, it's possible administrators have whitelisted setup.exe :shrug:

I do think random filename is probably the best option though, despite this.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31a33e1b67e7651284349bd30f5630e90e5b1dda

commit 31a33e1b67e7651284349bd30f5630e90e5b1dda
Author: Greg Thompson <grt@chromium.org>
Date: Fri Aug 04 13:30:59 2017

Report finer-grained errors for failures to launch setup.exe.

Specifically, this replaces exit code 106 (COULD_NOT_CREATE_PROCESS)
with six new codes to help diagnose these failures.

BUG=672813

Change-Id: I6a482761c34ae06c4f438aa2a30d7bd69afdf819
Reviewed-on: https://chromium-review.googlesource.com/601987
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492009}
[modify] https://crrev.com/31a33e1b67e7651284349bd30f5630e90e5b1dda/chrome/installer/mini_installer/exit_code.h
[modify] https://crrev.com/31a33e1b67e7651284349bd30f5630e90e5b1dda/chrome/installer/mini_installer/mini_installer.cc
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 6

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by grt@chromium.org, Aug 31

Status: Available (was: Untriaged)
►

Sign in to add a comment