New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672805 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Dragging bookmarked page from bookmark bar to the omnibox opens in a different tab instead of current tab

Project Member Reported by brajkumar@chromium.org, Dec 9 2016

Issue description

Chrome Version: 57.0.2946.0 Dev
OS: Mac OS 10.12, 10.11

Note: This issue is specific to Mac OS

What steps will reproduce the problem?
(1) Open chrome and navigate to facebook.com or any webpage
(2) Bookmark the page
(3) Bring the bookmark bar on top (Ctrl+Shift+B)
(4) Open a new tab
(5) Drag the bookmarked page (facebook.com) to the omnibox from bookmark bar

What is the expected result?
Facebook.com should open in the current tab

What happens instead?
Fcaebook.com opens in a different tab instead of the current tab

Bisect information:
--------------------
Using the per-revision bisect providing the bisect results,

Good build: 57.0.2926.0
Bad build:  57.0.2931.0

You are probably looking for a change made after 434123 (known good), but no later than 434124 (first known bad).

CHANGE-LOG URL:
---------------------------------------
https://chromium.googlesource.com/chromium/src/+log/cb3e5ca8d303f10841d9985ff350d9fcbca49c9d..d2e643efc4cceed77e046658a588f1559f1b1e88

From the CL above, assigning the issue to the concern owner
Review-Url: https://codereview.chromium.org/2502483002

shahriar.rostami/erikchen@ - Unable to find the author of the file in the owners list, so assigning to @erikchen for more updates. Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Adding RB-Beta since this issue is broken in M-57, please feel free to edit if this is not the case.

Thanks!
 
Actual Behavior.mp4
687 KB View Download
Expected Behavior.mp4
669 KB View Download
I'll investigate this as it might be because of my recent CL in this part.

Comment 2 by ajha@chromium.org, Dec 14 2016

shahriar.rostami@: Can we get an update on this issue.
shahriar: Please let us know soon, otherwise the default solution will be to revert your CL.
erikchen@ I'll submit my patch by tomorrow night. Sorry it was a hectic week for me.
Thanks for the update. Our policy is to revert first, then reland with the fix. When you reland, please:

submit a patchset that has the same contents as your previous CL. Then submit a patchset which includes your new changes - that way we only have to review the new changes.
Status: Fixed (was: Assigned)
CL was reverted: https://codereview.chromium.org/2572363002/

Sign in to add a comment