New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672767 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

DetailsPanel/FileManagerDetailsPanelBrowserTest.Test/1 flaky timeouts on Linux ChromiumOS Tests (dbg)(1)

Project Member Reported by grt@chromium.org, Dec 9 2016

Issue description

This test regularly times out on this particular debug bot.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=DetailsPanel%2FFileManagerDetailsPanelBrowserTest.Test%2F1&testType=browser_tests

Looks like it occasionally times out on Linux Chromium OS ASan LSan Tests (1), too.
 

Comment 1 by grt@chromium.org, Dec 9 2016

Cc: hirono@chromium.org fukino@chromium.org
+OWNERS

Comment 2 by fukino@chromium.org, Dec 12 2016

Owner: oka@chromium.org
oka@, I guess that the details panel function has already been integrated to quick view, and this test does not make sense anymore.

If it is the case, could you remove the test along with the details panel implementation?

Comment 3 by oka@chromium.org, Dec 12 2016

Yes. Will do.

Comment 4 by oka@chromium.org, Dec 12 2016

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86cc6307099df2aa19fac30eae8bbae90bbb57cb

commit 86cc6307099df2aa19fac30eae8bbae90bbb57cb
Author: oka <oka@chromium.org>
Date: Mon Dec 12 09:20:09 2016

Remove details panel.

Details panel was being developed under a flag, but has been replaced
with Quick View and is no longer needed.

BUG= 672767 
TEST=Manually tested that FileManager successfully launches using
Linux. git cl try.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2565333002
Cr-Commit-Position: refs/heads/master@{#437836}

[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/chrome/browser/about_flags.cc
[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/chromeos/chromeos_switches.cc
[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/chromeos/chromeos_switches.h
[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/ui/file_manager/file_manager/foreground/css/file_manager.css
[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/ui/file_manager/file_manager/foreground/js/app_state_controller.js
[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/ui/file_manager/file_manager/foreground/js/main_scripts.js
[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/ui/file_manager/file_manager/foreground/js/main_window_component.js
[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/ui/file_manager/file_manager/foreground/js/metadata_update_controller.js
[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp
[delete] https://crrev.com/44e989098aaaddeb9f0ee857282bc8cdaa1cc3d1/ui/file_manager/file_manager/foreground/js/ui/details_container.js
[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js
[delete] https://crrev.com/44e989098aaaddeb9f0ee857282bc8cdaa1cc3d1/ui/file_manager/file_manager/foreground/js/ui/multi_file_details.js
[delete] https://crrev.com/44e989098aaaddeb9f0ee857282bc8cdaa1cc3d1/ui/file_manager/file_manager/foreground/js/ui/single_file_details.js
[modify] https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb/ui/file_manager/file_manager/main.html
[delete] https://crrev.com/44e989098aaaddeb9f0ee857282bc8cdaa1cc3d1/ui/file_manager/integration_tests/file_manager/details_panel.js

Comment 6 by oka@chromium.org, Dec 12 2016

Fixed.

2016年12月12日(月) 18:24 bugdroid1 via monorail <
monorail+v2.3275348242@chromium.org>:

Comment 7 by oka@chromium.org, Dec 14 2016

Status: Fixed (was: Started)

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58
Status: Verified (was: Fixed)

Sign in to add a comment