New issue
Advanced search Search tips

Issue 672763 link

Starred by 3 users
Status: Fixed
Owner:
thomasanderson@chromium.org
Closed: Dec 2016
Cc:
ajha@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Close button gets focussed on pin/unpin on any tab

Project Member Reported by ajha@chromium.org, Dec 9 2016 
Chrome Version: 57.0.2946.0
OS: Linux Ubuntu 14.04.

What steps will reproduce the problem?
(1) Launch chrome and open any tab.
(2) Pin/ Unpin any tab and observe the close button.


What is the expected result?
> Close button shouldn't be focused on pin/unpin of any tab.

What happens instead?
> Close button is focused on pin/unpin of any tab.
> Doesn't loose focus even on page refresh.
 
Please use labels and text to provide additional information.
> This is Linux specific regression issue broken in M-56.

Last good build: 56.0.2888.0
First bad build: 56.0.2889.0

Changelog:
==========
https://chromium.googlesource.com/chromium/src/+log/77097e70751d4ecfb59e321fe4da63401060833a..6753a182d50ded7ddcbb91304bf71c6408c49f52

thomasanderson@: Could you please take a look at this.

Attached is the screen-cast of the actual and expected behavior.

Thank you!
PinCloseFocus_Actual.mp4
2.3 MB View Download
PinCloseFocus_Expected.mp4
1.4 MB View Download

Comment 1 by kavvaru@chromium.org, Dec 12 2016 

Able to reproduce the issue on Ubuntu 14.04 using chrome version 57.0.2946.0.

thomasanderson@ Please look into this issue.

Thanks,

Comment 2 by thomasanderson@chromium.org, Dec 12 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12871d4be95f2ed2899c35a10332618034ad78d2

commit 12871d4be95f2ed2899c35a10332618034ad78d2
Author: thomasanderson <thomasanderson@google.com>
Date: Tue Dec 13 17:20:09 2016

X11: Reset dispatching event when nested message loop ends

BUG= 672763 

Review-Url: https://codereview.chromium.org/2568233003
Cr-Commit-Position: refs/heads/master@{#438203}

[modify] https://crrev.com/12871d4be95f2ed2899c35a10332618034ad78d2/ui/events/platform/x11/x11_event_source.cc
[modify] https://crrev.com/12871d4be95f2ed2899c35a10332618034ad78d2/ui/events/platform/x11/x11_event_source.h
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13 2016

Labels: merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/348ea87fd00dc217a9d6e7b372386627785c3628

commit 348ea87fd00dc217a9d6e7b372386627785c3628
Author: thomasanderson <thomasanderson@chromium.org>
Date: Tue Dec 13 18:47:29 2016

[Merge to M56] X11: Reset dispatching event when nested message loop ends

> Review-Url: https://codereview.chromium.org/2568233003
> Cr-Commit-Position: refs/heads/master@{#438203}

BUG= 672763 
NOTRY=true
NOPRESUBMIT=true
TBR=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2575563002
Cr-Commit-Position: refs/branch-heads/2924@{#476}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/348ea87fd00dc217a9d6e7b372386627785c3628/ui/events/platform/x11/x11_event_source.cc
[modify] https://crrev.com/348ea87fd00dc217a9d6e7b372386627785c3628/ui/events/platform/x11/x11_event_source.h

Comment 5 by thomasanderson@chromium.org, Dec 13 2016

Status: Fixed (was: Started)

Comment 6 by tkonch...@chromium.org, Dec 14 2016

Labels: TE-Verified-56.0.2924.28 TE-Verified-M56
Tested the same on Linux 14.04 chrome version 56.0.2924.28 - Close button is not focused on pin/unpin of any tab.

Please find the screen cast

Fix works as expected
672763.ogv
868 KB View Download
►

Sign in to add a comment