New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 672746 link

Starred by 2 users
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: [Persistence2] exception is thrown on reload

Project Member Reported by lushnikov@chromium.org, Dec 9 2016 
What steps will reproduce the problem?
1. Enable persistence2
2. Open elements panel
3. Make sure there's at least one green checkmark in styles sidebar pane
4. reload page

What is the expected result?
Page reloads without exceptions.

What happens instead of that?
An exception is thrown:

Uncaught (in promise) DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
    at HTMLSpanElement.Element.removeChild (chrome-devtools://devtools/custom/ui/Widget.js:750:41)
    at Function._updateLinkDecorations (chrome-devtools://devtools/custom/components/Linkifier.js:330:14)
    at onLinkIconChanged (chrome-devtools://devtools/custom/components/Linkifier.js:68:30)
    at Persistence.PersistenceUtils.LinkDecorator.dispatchEventToListeners (chrome-devtools://devtools/custom/common/Object.js:99:29)
    at Persistence.PersistenceUtils.LinkDecorator._bindingChanged (chrome-devtools://devtools/custom/persistence/PersistenceUtils.js:41:10)
    at Persistence.Persistence.dispatchEventToListeners (chrome-devtools://devtools/custom/common/Object.js:99:29)
    at Persistence.Persistence._onBindingCreated (chrome-devtools://devtools/custom/persistence/Persistence.js:60:10)
    at Persistence.Automapping.onBinding (chrome-devtools://devtools/custom/persistence/Automapping.js:169:30)
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75e3ed0f6a7521437691659d27664576906c604d

commit 75e3ed0f6a7521437691659d27664576906c604d
Author: lushnikov <lushnikov@chromium.org>
Date: Sat Dec 10 02:07:17 2016

DevTools: fix exception in anchor icon decoration

Since the anchor's text might have been changed via the textContent
assignment, the icon might not be attached.

This patch makes sure icon is attached to the dom before attempting to
remove it.

BUG= 672746 
R=dgozman

Review-Url: https://codereview.chromium.org/2552883014
Cr-Commit-Position: refs/heads/master@{#437724}

[modify] https://crrev.com/75e3ed0f6a7521437691659d27664576906c604d/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

Comment 2 by lushnikov@chromium.org, Dec 10 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment