Layout Test http/tests/security/mixedContent/websocket/insecure-websocket-in-secure-page-worker.html is flaky on Linux Trusty Leak |
||||||||||
Issue descriptionThe following layout test is flaky on Linux Trusty Leak: http/tests/security/mixedContent/websocket/insecure-websocket-in-secure-page-worker.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fsecurity%2FmixedContent%2Fwebsocket%2Finsecure-websocket-in-secure-page-worker.html
,
Dec 9 2016
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/222cb92a34f4623c308bec1c417df507cabb61c2 commit 222cb92a34f4623c308bec1c417df507cabb61c2 Author: yhirano <yhirano@chromium.org> Date: Fri Dec 09 08:36:55 2016 Mark http/tests/security/mixedContent/websocket/insecure-websocket-in-secure-page-worker.html as leaky BUG= 672740 NOTRY=true TBR=asargent@chromium.org, grt@chromium.org, vasilii@chromium.org Review-Url: https://codereview.chromium.org/2562943002 Cr-Commit-Position: refs/heads/master@{#437497} [modify] https://crrev.com/222cb92a34f4623c308bec1c417df507cabb61c2/third_party/WebKit/LayoutTests/LeakExpectations
,
Dec 19 2016
Can we triage this? I assume WebSocket folks can take this?
,
Dec 19 2016
Tentatively assigning to me...
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fab77db556349d2f3c5cb893d5fba4f5f851799a commit fab77db556349d2f3c5cb893d5fba4f5f851799a Author: yhirano <yhirano@chromium.org> Date: Tue Dec 20 03:49:33 2016 Fix a resource leak in insecure-websocket-in-secure-page-worker.html This is a speculative fix for a leak reported by a leak bot. BUG= 672740 Review-Url: https://codereview.chromium.org/2587943002 Cr-Commit-Position: refs/heads/master@{#439696} [modify] https://crrev.com/fab77db556349d2f3c5cb893d5fba4f5f851799a/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/websocket/insecure-websocket-in-secure-page-worker.html
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/983562c0a6d25e3782a6170cc4d81dd2f1b5fe6d commit 983562c0a6d25e3782a6170cc4d81dd2f1b5fe6d Author: shimazu <shimazu@chromium.org> Date: Wed Dec 21 06:22:25 2016 Mark insecure-websocket-in-secure-page-worker-allowed.html as leaky BUG= 672740 TBR=asargent@chromium.org, grt@chromium.org, vasilii@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2592003002 Cr-Commit-Position: refs/heads/master@{#440042} [modify] https://crrev.com/983562c0a6d25e3782a6170cc4d81dd2f1b5fe6d/third_party/WebKit/LayoutTests/LeakExpectations
,
Jan 5 2017
It's still leaking (with less frequency than before).
,
Feb 8 2017
I gave up. Feel free to take this issue.
,
Nov 10 2017
,
Feb 18 2018
,
Nov 15
According to the flakiness dashboard, this seems no longer leaky. I guess off-the-main-thread WebSocket or other loader refactoring may fix or hide this issue. I'll update the test expectation...
,
Nov 15
Wait, http/tests/security/mixedContent/websocket/insecure-websocket-in-secure-page-worker-allowed.html still sometimes leaks on WebKit Linux Trusty Leak. I'll keep this as is... (I checked only http/tests/security/mixedContent/websocket/insecure-websocket-in-secure-page-worker.html :p)
,
Nov 15
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=insecure-websocket-in-secure-page-worker.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=websocket%2Finsecure-websocket-in-secure-page-worker-allowed.html
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c27d3b071f4e8c78f3f1d6c4cb3f06a6f673188 commit 7c27d3b071f4e8c78f3f1d6c4cb3f06a6f673188 Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Nov 16 00:41:23 2018 Fix leak on insecure-websocket-in-secure-page-worker-allowed.html Bug: 672740 Change-Id: I2246a0d840f8d62cfb1026d53195c78cd12f27d9 Reviewed-on: https://chromium-review.googlesource.com/c/1337223 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#608602} [modify] https://crrev.com/7c27d3b071f4e8c78f3f1d6c4cb3f06a6f673188/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/websocket/insecure-websocket-in-secure-page-worker-allowed.html [modify] https://crrev.com/7c27d3b071f4e8c78f3f1d6c4cb3f06a6f673188/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/websocket/resources/expect-successful-construction.js [modify] https://crrev.com/7c27d3b071f4e8c78f3f1d6c4cb3f06a6f673188/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/websocket/resources/expect-throw-on-construction.js
,
Nov 16
Tentatively assigning to me.
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87c44585f802924dcbafe4fba84de86f8a16c333 commit 87c44585f802924dcbafe4fba84de86f8a16c333 Author: Yutaka Hirano <yhirano@chromium.org> Date: Mon Nov 19 08:39:16 2018 Remove WebSocket + MIX + Worker tests from LeakExpectations They are no longer leaky. Bug: 672740 Change-Id: I327d3f5c073008ec092dc3f94bb00701d05cd183 Reviewed-on: https://chromium-review.googlesource.com/c/1341735 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#609208} [modify] https://crrev.com/87c44585f802924dcbafe4fba84de86f8a16c333/third_party/WebKit/LayoutTests/LeakExpectations
,
Nov 19
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by yhirano@chromium.org
, Dec 9 2016