run-bindings-tests doesn't seem to work |
||||
Issue descriptionWhat steps will reproduce the problem? (1) third_party/WebKit/Tools/Scripts/run-bindings-tests What is the expected result? bindings tests should run What happens instead? It outputs following error message: No tests to run. zsh: exit 1 ./third_party/WebKit/Tools/Scripts/run-bindings-tests Please use labels and text to provide additional information. Adding --all didn't work. Also, presubmit checks are failing due to the same cause. I think this is happening after https://codereview.chromium.org/2554503004/
,
Dec 9 2016
Looking at the code of typ, it returns 1 if no tests exist, and it is impossible to distinguish it from actual test failures. So what we can do is either of - to change typ to return 0 (success code) - check if the directory has any unit tests before calling typ.main() - comment out the added code in run-bindings-tests until we add a unit test.
,
Dec 9 2016
,
Dec 9 2016
,
Dec 9 2016
Patch ready: https://codereview.chromium.org/2557403003
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e41b9ae700214d41cf25c3bd9606aacf13209727 commit e41b9ae700214d41cf25c3bd9606aacf13209727 Author: dglazkov <dglazkov@chromium.org> Date: Fri Dec 09 18:50:01 2016 Temporarily remove unit testing from run-bindings-tests. Turns out, typ treats the absence of the unit tests as failure, and we don't have any tests at the moment. R=peria,bashi,haraken BUG= 672738 Review-Url: https://codereview.chromium.org/2557403003 Cr-Commit-Position: refs/heads/master@{#437599} [modify] https://crrev.com/e41b9ae700214d41cf25c3bd9606aacf13209727/third_party/WebKit/Tools/Scripts/run-bindings-tests
,
Dec 10 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bashi@chromium.org
, Dec 9 2016Owner: dglazkov@chromium.org
Status: Assigned (was: Untriaged)