New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672726 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 686904



Sign in to add a comment

Autotest: Delete email_manager for stacktraces

Project Member Reported by pprabhu@chromium.org, Dec 9 2016

Issue description


We send emails from the autotest lab on various conditions.

Instead, migrate all such monitoring to viceroy based alerts. We're unifying our monitoring to monarch/viceroy.

This is a tracker bug for the email cleanup.
 

Comment 1 by autumn@chromium.org, Dec 13 2016

Cc: jrbarnette@chromium.org
Labels: metrics Hotlist-Fixit OS-Linux

Comment 2 by autumn@chromium.org, Dec 13 2016

Labels: -OS-Linux
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c29b4c7ec10db41f38e0361febe9846a95629b5a

commit c29b4c7ec10db41f38e0361febe9846a95629b5a
Author: Aviv Keshet <akeshet@chromium.org>
Date: Thu Dec 15 06:27:35 2016

autotest: delete some email alerts; replace some with monarch metrics

For email alerts that seem (based on searching my email) to never be
sent, I simply deleted them.

For those that are sent sometimes and seem easily amenable to a monarch
metric instead, I changed them to a metric.

This is a first step; there are still many remaining unneccesary email
alerts.

BUG=chromium:672726
TEST=None

Change-Id: Ib1d3715e618623faa16f3faaceabf4218dbad49a
Reviewed-on: https://chromium-review.googlesource.com/420468
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/c29b4c7ec10db41f38e0361febe9846a95629b5a/scheduler/monitor_db_cleanup.py
[modify] https://crrev.com/c29b4c7ec10db41f38e0361febe9846a95629b5a/scheduler/drone_manager.py
[modify] https://crrev.com/c29b4c7ec10db41f38e0361febe9846a95629b5a/scheduler/monitor_db.py
[modify] https://crrev.com/c29b4c7ec10db41f38e0361febe9846a95629b5a/scheduler/scheduler_config.py
[modify] https://crrev.com/c29b4c7ec10db41f38e0361febe9846a95629b5a/global_config.ini

Cc: akes...@chromium.org
aviv, what work remains on this bug? 
There still work left here. We're done when this query returns empty: https://cs.corp.google.com/search/?q=email_manager&m=100&sq=package:chromeos+file:src/third_party/autotest/files&type=cs
Labels: -current-issue
Owner: pprabhu@chromium.org
sounds like pprahbu@ is owning, assigning to him 
I talk too much :(
Owner: akes...@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/82c508c92026bad3c2165ac858e2578bc6db479a

commit 82c508c92026bad3c2165ac858e2578bc6db479a
Author: Aviv Keshet <akeshet@chromium.org>
Date: Tue Jan 03 22:10:17 2017

autotest: turn pidfile email alert into a monarch metrics

BUG=chromium:672726
TEST=None

Change-Id: I784bd962e9667b729684caf0effb6ddf892e2252
Reviewed-on: https://chromium-review.googlesource.com/424673
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/82c508c92026bad3c2165ac858e2578bc6db479a/scheduler/pidfile_monitor.py

 Issue 671254  has been merged into this issue.
Labels: -Hotlist-Fixit
Blockedon: 686904
Cc: dshi@chromium.org pho...@chromium.org
Owner: ----
Status: Available (was: Untriaged)
I'm tempted to say we just delete email_manager for stacktraces entirely.

Comment 14 by dshi@chromium.org, May 26 2017

If there is no consumer of the stacktrace alerts, and monarch can detect repeated service crash/restart cycle, delete email_manager for stacktraces entirely is all reasonable.
> I'm tempted to say we just delete email_manager for stacktraces entirely.

Yes, please.

http://shortn/_DcIXLquqwR

Labels: Hotlist-Fixit
Summary: Autotest: Delete email_manager for stacktraces (was: Autotest: Replace email_manager.manager.log_stacktrace and friends with monarch metrics)
Components: -Infra>Client>ChromeOS Infra>Client>ChromeOS>Test
Labels: -Pri-2 Pri-3
Owner: zamorzaev@chromium.org
Status: Assigned (was: Available)

Sign in to add a comment