New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672725 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Factory: To Revise The Wrong Statements in README.md under Root Folder of Factory Repo

Project Member Reported by marcochen@chromium.org, Dec 9 2016

Issue description

After reading the README.md [1] under root folder of factory repo (master branch currently), there are some wrong statements which should be revised. Give some examples here:

1. 
> or running make BOARD=$BOARD toolkit inside factory repo).
Basically variables in the environment become Make variables already [2] therefore there is no neccesary to have "BOARD=$BOARD".

2. 
> Build manually. In factory repo, run make --board=$BOARD toolkit
s/--board=$BOARD//

3. 
> The factory image and test image can be combined into an SSD image
s/factory/factory test/ and s/test/release/

4. others

[1] https://chromium.googlesource.com/chromiumos/platform/factory/+/103ca1f72e67bf73f31aacd5cf3844d3773b0c94/README.md
[2] https://www.gnu.org/software/make/manual/html_node/Environment.html
 
Cc: moch@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/7ef098961461e784a102484d7a65efd210a7cb96

commit 7ef098961461e784a102484d7a65efd210a7cb96
Author: Marco Chen <marcochen@chromium.org>
Date: Tue Dec 13 04:58:53 2016

README.md: Revise wrong statements.

To revise wrong commands and statements.

BUG= chromium:672725 
TEST=none

Change-Id: Ie7a29182c7b02e47791f47a7e1c31135722c07ee
Reviewed-on: https://chromium-review.googlesource.com/418543
Commit-Ready: Marco Chen <marcochen@chromium.org>
Tested-by: Marco Chen <marcochen@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/7ef098961461e784a102484d7a65efd210a7cb96/README.md

Status: Verified (was: Untriaged)

Sign in to add a comment