Issue metadata
Sign in to add a comment
|
Regression: Weird focus ring is seen on Uber Tray. |
||||||||||||||||||||||
Issue descriptionChrome Version: 57.0.2944.0/9062.0.0 dev channel Jerry,Quawks,Paine OS: Chrome OS What steps will reproduce the problem? (1)Recover the build via USB/Sign in with valid credentials and Sign out (2)Hit tab key till you reach Uber Tray and Observe blue focus ring over Uber tray.(Please refer screenshot) Expected: Focus ring should be properly seen on Uber Tray. Actual: Instead weird focus ring is seen. This is regression issue as focus ring is properly seen in 56.0.2924.20/9000.22.0 dev channel peach pit. Attaching screenshots for reference. @tbuckley- Please confirm the behavior.
,
Dec 9 2016
Noticed this yesterday. It's been there awhile, but got turned on by default with MD shelf (https://codereview.chromium.org/2454393002).
,
Dec 9 2016
,
Dec 12 2016
There seems to have been a lot of churn around this rectangle in the last few weeks: https://codereview.chromium.org/2513823002/diff/40001/ash/common/system/tray/tray_background_view.cc https://codereview.chromium.org/2527513002/diff/80001/ash/common/system/tray/tray_background_view.cc I'm not sure why the rectangle is currently being drawn wrong. Possibly due to the need for different insets for MD and non-MD shelves. Anyway, here's a proposed CL which fixes things, at least on my setup: https://codereview.chromium.org/2569773002 I've attached screenshots of the focus rect from the login and desktop screens, for both MD and non-MD (e.g., --ash-md=disabled) shelves.
,
Dec 12 2016
A few additional notes: 1) Also tested this at 2x resolution, rectangles looked fine. 2) The focus rect on the SysTray is 2px and a darker blue than the 1px focus rect seen around other login screen elements (e.g., Shut down, Add person, etc). Do we want to correct this, and make them the same?
,
Dec 13 2016
,
Dec 13 2016
Re #5 (2), yes all of the focus rects should have a consistent appearance. estade@ is updating the focus rect appearance for MD shelf/system menu in M-57, and I'm not sure if that is already on his radar.
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed39f2cb627cd5deb00a0d5f1fea0cddd48c8cc4 commit ed39f2cb627cd5deb00a0d5f1fea0cddd48c8cc4 Author: glevin <glevin@chromium.org> Date: Thu Dec 22 19:49:09 2016 Fix SysTray focus rect position BUG= 672723 TEST=On login, lock, and desktop screens, with and without --ash-md=disabled flag, move focus to SysTray, and verify that focus rect is in correct position. Review-Url: https://codereview.chromium.org/2569773002 Cr-Commit-Position: refs/heads/master@{#440476} [modify] https://crrev.com/ed39f2cb627cd5deb00a0d5f1fea0cddd48c8cc4/ash/common/system/tray/actionable_view.cc [modify] https://crrev.com/ed39f2cb627cd5deb00a0d5f1fea0cddd48c8cc4/ash/common/system/tray/actionable_view.h [modify] https://crrev.com/ed39f2cb627cd5deb00a0d5f1fea0cddd48c8cc4/ash/common/system/tray/tray_background_view.cc [modify] https://crrev.com/ed39f2cb627cd5deb00a0d5f1fea0cddd48c8cc4/ash/common/system/tray/tray_background_view.h
,
Jan 3 2017
,
Jan 10 2017
Verified on ChromeOS 9167.0.0, 57.0.2976.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jbanavatu@chromium.org
, Dec 9 2016