read-draw-when-missing-image.html fails |
|||
Issue descriptionThis is a new test for WebGL 2.0.1. When the attachment point(s) in read fbo miss image, and such an attachment point is accessed by reading/blitting, it should generate INVALID_OPERATION. I will fix it.
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25231a97c1a3eba9e26ff8fa5601e29b21672b73 commit 25231a97c1a3eba9e26ff8fa5601e29b21672b73 Author: yunchao.he <yunchao.he@intel.com> Date: Wed Dec 14 11:00:34 2016 [Command buffer]: Generate INVALID_OPERATION if designated attachments in read fb miss image during blitting BUG= 672719 TEST=conformance2/rendering/read-draw-when-missing-image.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2570823002 Cr-Commit-Position: refs/heads/master@{#438477} [modify] https://crrev.com/25231a97c1a3eba9e26ff8fa5601e29b21672b73/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/25231a97c1a3eba9e26ff8fa5601e29b21672b73/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/25231a97c1a3eba9e26ff8fa5601e29b21672b73/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a90f25c0439895a5c7dcaa9861a3dc06c9b9ad3a commit a90f25c0439895a5c7dcaa9861a3dc06c9b9ad3a Author: sugoi <sugoi@chromium.org> Date: Wed Dec 14 15:53:19 2016 Revert of [Command buffer]: Generate INVALID_OPERATION if designated attachments in read fb miss image (patchset #5 id:80001 of https://codereview.chromium.org/2570823002/ ) Reason for revert: Broke Linux NVidia GPU FYI bot. See: https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28NVIDIA%29 Original issue's description: > [Command buffer]: Generate INVALID_OPERATION if designated attachments in read fb miss image during blitting > > BUG= 672719 > TEST=conformance2/rendering/read-draw-when-missing-image.html > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/25231a97c1a3eba9e26ff8fa5601e29b21672b73 > Cr-Commit-Position: refs/heads/master@{#438477} TBR=zmo@chromium.org,kbr@chromium.org,qiankun.miao@intel.com,yunchao.he@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 672719 Review-Url: https://codereview.chromium.org/2578633002 Cr-Commit-Position: refs/heads/master@{#438524} [modify] https://crrev.com/a90f25c0439895a5c7dcaa9861a3dc06c9b9ad3a/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/a90f25c0439895a5c7dcaa9861a3dc06c9b9ad3a/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/a90f25c0439895a5c7dcaa9861a3dc06c9b9ad3a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc
,
Dec 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd697d665dfbc3e40166ab144b5573413628e2e4 commit fd697d665dfbc3e40166ab144b5573413628e2e4 Author: yunchao.he <yunchao.he@intel.com> Date: Fri Dec 16 09:56:07 2016 [Command buffer]: Generate INVALID_OPERATION if designated attachments in read fb miss image during blitting BUG= 672719 TEST=conformance2/rendering/read-draw-when-missing-image.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/25231a97c1a3eba9e26ff8fa5601e29b21672b73 Review-Url: https://codereview.chromium.org/2570823002 Cr-Original-Commit-Position: refs/heads/master@{#438477} Cr-Commit-Position: refs/heads/master@{#439080} [modify] https://crrev.com/fd697d665dfbc3e40166ab144b5573413628e2e4/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/fd697d665dfbc3e40166ab144b5573413628e2e4/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/fd697d665dfbc3e40166ab144b5573413628e2e4/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3778159fc2c65c4d7dabaa0a5b07653aa29343d4 commit 3778159fc2c65c4d7dabaa0a5b07653aa29343d4 Author: yunchao.he <yunchao.he@intel.com> Date: Tue Dec 20 02:47:56 2016 [Command buffer] Fix a bug for early return in blitFramebuffer BUG= 672719 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2588653002 Cr-Commit-Position: refs/heads/master@{#439680} [modify] https://crrev.com/3778159fc2c65c4d7dabaa0a5b07653aa29343d4/gpu/command_buffer/service/gles2_cmd_decoder.cc
,
Dec 20 2016
> [Command buffer]: Generate INVALID_OPERATION if designated attachments in read fb miss image during blitting Yunchao, any chance this crash is caused by this patch? https://bugs.chromium.org/p/chromium/issues/detail?id=675819 (Or maybe is that what you just fixed?)
,
Dec 20 2016
I will submit a patch to suppress the conformance test and take a look. I saw a driver bug (and crash) on Linux/nvidia and Win/nvidia about this test, here is a fix: https://codereview.chromium.org/2581973002/ .
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/629f4bd28118cac07ebfde9aea0d7005789b181b commit 629f4bd28118cac07ebfde9aea0d7005789b181b Author: yunchao.he <yunchao.he@intel.com> Date: Tue Dec 20 05:50:04 2016 suppress the webgl2 conformance test to prevent bot failure BUG= 672719 , 675819 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2590103002 Cr-Commit-Position: refs/heads/master@{#439720} [modify] https://crrev.com/629f4bd28118cac07ebfde9aea0d7005789b181b/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b044d12cc9c568f23fa16100515794839cdc6795 commit b044d12cc9c568f23fa16100515794839cdc6795 Author: cwallez <cwallez@chromium.org> Date: Thu Dec 22 01:19:00 2016 WebGL CTS: remove suppression for passing test. This is equivalent to a revert of 629f4bd28118cac07ebfde9aea0d7005789b181b BUG= 672719 , 675819 TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2595943002 Cr-Commit-Position: refs/heads/master@{#440294} [modify] https://crrev.com/b044d12cc9c568f23fa16100515794839cdc6795/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9880858779bea48a0e826a296b19191dc4c4e12c commit 9880858779bea48a0e826a296b19191dc4c4e12c Author: yunchao.he <yunchao.he@intel.com> Date: Thu Dec 22 03:47:21 2016 [Command buffer]: Don't blit color buffer if draw buffers have no image during blitting BUG= 672719 TEST=conformance2/rendering/read-draw-when-missing-image.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2581973002 Cr-Commit-Position: refs/heads/master@{#440329} [modify] https://crrev.com/9880858779bea48a0e826a296b19191dc4c4e12c/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/9880858779bea48a0e826a296b19191dc4c4e12c/gpu/command_buffer/service/gles2_cmd_decoder.cc
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/66a41a28d88a52078edb2fd22af736d54c89fc54 commit 66a41a28d88a52078edb2fd22af736d54c89fc54 Author: He Yunchao <yunchao.he@intel.com> Date: Thu Dec 15 08:45:05 2016 Generate errors when read buffers are missing in BlitFramebuffer. The corresponding gl_tests has been updated too. BUG= 672719 Change-Id: Ief37bc397f7aa065bf99d6ebad0a1b50b1917dac Reviewed-on: https://chromium-review.googlesource.com/420469 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/66a41a28d88a52078edb2fd22af736d54c89fc54/src/tests/gl_tests/BlitFramebufferANGLETest.cpp [modify] https://crrev.com/66a41a28d88a52078edb2fd22af736d54c89fc54/src/libANGLE/validationES.cpp
,
Dec 23 2016
The bug is fixed in both Chromium-side and angle-side.
,
Dec 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8438beb74dd3443e928c2e53082dbde81ca1900 commit f8438beb74dd3443e928c2e53082dbde81ca1900 Author: jmadill <jmadill@chromium.org> Date: Fri Dec 23 16:29:06 2016 Roll ANGLE b8a580a..d5fe352 https://chromium.googlesource.com/angle/angle.git/+log/b8a580a..d5fe352 BUG= 676333 , 676689 , 672719 , 668223 , 630498 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2606473002 Cr-Commit-Position: refs/heads/master@{#440636} [modify] https://crrev.com/f8438beb74dd3443e928c2e53082dbde81ca1900/DEPS
,
Nov 27
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Dec 9 2016