Pass camera facing information to audio |
|||||||||||
Issue descriptionPass camera facing information here: https://chromium.googlesource.com/chromium/chromium/+/5b0874e7d87040fce31a6f862f1636d010025368/chromeos/audio/cras_audio_handler.cc Related issue: https://code.google.com/p/chrome-os-partner/issues/detail?id=56762
,
Dec 9 2016
,
Dec 9 2016
+Jenny and Will
,
Jan 5 2017
,
Jan 6 2017
Shenghao will start this on Monday to unblock Jenny
,
Jan 6 2017
,
Jan 6 2017
,
Jan 9 2017
,
Jan 12 2017
What is the status of this task? When will we have the code for the notification that audio code can tell the activation of the camera front vs. back?
,
Jan 13 2017
I will start work on it today. Will update this bug when I have progress.
,
Jan 16 2017
After looking into it a bit, I can't find any good ways to pass camera facing information in VideoCaptureManager ( https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/video_capture_manager.cc?cl=GROK&gsn=StartCaptureForClient&rcl=1484540488&l=640) to CrasAudioHandler. I propose the following: Add a callback registration API in VideoCaptureManager, and CrasAudioHandler would register callback which is called when a video device is ready to start capturing. The callback parameter would contain facing info. Any suggestions?
,
Jan 17 2017
+dylan who may have some ideas on how to architect this
,
Jan 17 2017
Ok. I discovered that my proposal is not feasible. //chromeos:chromeos can't depend on //content/browser:browser due to cyclic dependency: //ui/ozone:ozone -> //ui/ozone:platform -> //ui/platform_window:platform_window -> //ui/base:base -> //chromeos:chromeos -> //content/browser:browser -> //ui/ozone:ozone I need some advice from people who are familiar with this matter.
,
Jan 17 2017
Never mind. I kind of figured it out. Uploaded CL: https://codereview.chromium.org/2634263002/
,
Jan 19 2017
,
Feb 15 2017
The CL is in review.
,
Feb 20 2017
CL still in review
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77ec80cbdc1be45775bffd27605bfd9549f8a9a6 commit 77ec80cbdc1be45775bffd27605bfd9549f8a9a6 Author: shenghao <shenghao@chromium.org> Date: Wed Feb 22 20:14:18 2017 Pass camera facing info to audio client Pass camera facing info when camera is started to audio client so that active audio device can be switched according to camera facing. BUG= 672695 TEST=Print log in CrasAudioClientImpl::OnVideoCaptureStarted() and verify that facing info is correctly passed. Review-Url: https://codereview.chromium.org/2634263002 Cr-Commit-Position: refs/heads/master@{#452180} [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/chrome/browser/chromeos/chrome_browser_main_chromeos.cc [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/chromeos/BUILD.gn [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/chromeos/DEPS [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/chromeos/audio/cras_audio_handler.cc [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/chromeos/audio/cras_audio_handler.h [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/content/browser/renderer_host/media/media_capture_devices_impl.cc [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/content/browser/renderer_host/media/media_capture_devices_impl.h [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/content/browser/renderer_host/media/media_stream_manager.cc [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/content/browser/renderer_host/media/media_stream_manager.h [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/content/browser/renderer_host/media/video_capture_manager.cc [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/content/browser/renderer_host/media/video_capture_manager.h [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/content/browser/renderer_host/media/video_capture_manager_unittest.cc [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/content/common/media/media_stream_messages.h [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/content/public/browser/media_capture_devices.h [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/media/base/BUILD.gn [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/media/base/video_facing.h [modify] https://crrev.com/77ec80cbdc1be45775bffd27605bfd9549f8a9a6/media/capture/video/video_capture_device_descriptor.cc
,
Feb 22 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by shenghao@chromium.org
, Dec 9 2016