New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 672692 link

Starred by 1 user
Status: Fixed
Owner:
█ romax@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Test harness logs showing 2 time stamps

Project Member Reported by romax@chromium.org, Dec 9 2016 
like
12-08 18:09:04.911: OPNative | 2016 12 08 18:09:04: EvaluationTestScheduler Start schedule!
12-08 18:09:04.942: OPNative | 2016 12 08 18:09:04: EvaluationTestScheduler Start schedule!

we only need one when it's logged from event_logger.cc
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/825fa9c5a81c35e4040459b401ef679a171d49b4

commit 825fa9c5a81c35e4040459b401ef679a171d49b4
Author: romax <romax@chromium.org>
Date: Tue Dec 13 22:00:05 2016

[Offline Pages] Minor fix for log messages in event logger.

Since the custom logger used by test harness already contains timestamp,
we should remove the timestamp added in event logger for internal page.

BUG= 672692 

Review-Url: https://codereview.chromium.org/2562913002
Cr-Commit-Position: refs/heads/master@{#438304}

[modify] https://crrev.com/825fa9c5a81c35e4040459b401ef679a171d49b4/components/offline_pages/core/offline_event_logger.cc
[modify] https://crrev.com/825fa9c5a81c35e4040459b401ef679a171d49b4/components/offline_pages/core/offline_event_logger_unittest.cc

Comment 2 by romax@chromium.org, Dec 13 2016

Status: Fixed (was: Started)
►

Sign in to add a comment