New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672688 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 467304
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Removing inline event handler from the "Elements" view dosen't work.

Reported by whosekit...@gmail.com, Dec 9 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.21 Safari/537.36

Steps to reproduce the problem:
1. Open an HTML file containing inline event handlers (e.g. onclick="alert(1);"
2. Remove "onclick" attribute with the Developer Tools' "Elements" view.

What is the expected behavior?
The event handler doesn't work anymore.

What went wrong?
But the "onclick" event handler still works.
In the case of the attached files, alert still pops by clicking the body element.

Did this work before? N/A 

Chrome version: 56.0.2924.21  Channel: beta
OS Version: 10.0
Flash Version: Shockwave Flash 24.0 r0
 
inline-handlers.html
473 bytes View Download

Comment 1 by ajha@chromium.org, Dec 12 2016

Labels: M-56
Cc: tkonch...@chromium.org
Labels: Needs-Feedback
Tested the same on win10 chrome version 56.0.2924.21 and canary 57.0.2949.0 - alert displays on clicking the page

The same is observed in firefox browser as well

This doesn't seem to be a chrome specific issue. Could you please try the same in other browsers and update the thread
> The same is observed in firefox browser as well

Really!? As longs as I've tested, it isn't observed in Firefox (UA: "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0")
IE11 doesn't have same issue either (UA: "Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; CMNTDFJS; GWX:QUALIFIED; rv:11.0) like Gecko").

Wait for Edge and others on Win10. Here I'm using Win7.
Tested this issue on Win-10 using chrome reported version #56.0.2924.21 and latest canary #57.0.2949.0.

Attached a screen cast (behavior in chrome and firefox) for reference.

Following are the steps followed to reproduce the issue.
------------
1. Opened the attached html in chrome browser.
2. Clicked on the body element.
3. Observed that alert pops up on clicking the body element.

Note: The same is observed in firefox also.

whosekiteneverfly@ - Could you please verify the screencast and please let us  know if anything missed from our side.

Thanks...!!

672688.mp4
2.4 MB View Download
Thanks for showing the screen cast.
But when is the event handler removed in the screen cast?

It looks that the second step to reproduce is not done...

> 2. Remove "onclick" attribute with the Developer Tools' "Elements" view.
I can't repro this in m55 or m57.

Will try again with m56..
I've made screencasts for firefox and chrome.
Both browsers are on my personal machine (same as the one I used to report this issue)
And Firefox version is 50.0.2.
Chrome is now 56.0.2924.28 beta.
chrome.gif
252 KB View Download
firefox.gif
167 KB View Download
Cc: kavvaru@chromium.org eustas@chromium.org
Components: Blink>JavaScript
Labels: -Type-Bug -Pri-2 -Needs-Feedback hasbisect OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: haraken@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.12.1 using chrome version 55.0.2883.87 and canary 57.0.2952.0.

This is regression issue broken in M34.Please find the bisect information as below
Narrow Bisect::
Good::34.0.1837.0  -- (build revision -- 250689)
Bad:: 34.0.1839.0  -- (build revision --  250996)

CHANGELOG URL:
====================  https://chromium.googlesource.com/chromium/src/+log/f7670318d01f066b46dd199e11e18b4d13428b01..8d613aab7e400fcde8829d8a55138230c8d5c3b8

BLINK CHANGELOG URL:
=====================  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.htmlurl=/trunk&range=167002%3A167000

Possible suspects::
https://codereview.chromium.org/149803005
https://codereview.chromium.org/159903005

haraken@ could you please look into this issue if it is related to your change,else please help us in finding the appropriate owner for this issue.

Thanks,
Just to Update:
Still able to reproduce the issue on Ubuntu 14.04 using latest chrome version 57.0.2969.0.

haraken@ Could you please look into this issue.

Thanks!
Cc: haraken@chromium.org
Components: Blink>Bindings
Owner: yukishiino@chromium.org
shiino-san: This looks like a bug I caused three years ago, but would you mind taking a look at this?

Able to reproduce the issue on windows 7 using chrome version 57.0.2976.0.

yukishiino@ Please look into this issue.

Thanks,
I cannot reproduce this issue with 57.0.2970.0 dev on GNU/Linux.
Is this Windows-specific?

Just to update, still able to reproduce this issue on Ubuntu 14.04 and Mac 10.12.2 using chrome version #57.0.2970.0 and latest canary #57.0.2985.0.

Attaching screencast of Ubuntu 14.04 for reference

yukishiino@ - Could you please have a look into this issue. This issue is seen on mac and linux also.

Thanks...!!


672688.ogv
4.2 MB View Download
Cc: yukishiino@chromium.org
Owner: pfeldman@chromium.org
Confirmed a repro.  Probably it was my mistake that I failed to repro before.

pfeldman@, could you triage this issue in DevTools team?  I guess this is an issue of DevTools.  If DevTools called removeAttribute("onclick") internally, the event handler should be removed.
Mergedinto: 467304
Status: Duplicate (was: Assigned)

Sign in to add a comment