Layout Test paint/invalidation/resize-iframe-text.html fails on Mac |
|||
Issue descriptionThe following layout tests are failing on Mac: paint/invalidation/resize-iframe-text.html virtual/spinvalidation/paint/invalidation/resize-iframe-text.html The sheriff-o-matic says the regression range is chromium: 437334 - 437380.
,
Dec 9 2016
Here's the regression range: https://chromium.googlesource.com/chromium/src/+log/ad0b46843bbcca3ef126402974d9ceaaf136bef5%5E..f32ade75b611e31c6f43914a93c3f7067bcc8cce?pretty=fuller I think this may have been https://crrev.com/0cb78ded59f2d96e2ad2b0f9427146c23a3c4cc0
,
Dec 9 2016
Yeah, I was pretty surprised that I didn't get new rebaseline results for Mac there, when I requested it for all platforms (but the CL landed without problems, so what was I supposed to think?). I'll just mark it with [ NeedsRebaseline ] in TestExpectations now, or is there a better way?
,
Dec 9 2016
I think your patch landed due to a test flake where the CQ thought the test was failing without your patch [1,2]. Can you reland your patch with the regular rebaseline approach and just double-check that the mac results catch a passing run of the test? We should leave this marked as flaky on 10.10 in TestExpectations. Btw, I think it was a mistake that this test was marked as Crash. [1] https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/350425 [2] http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=paint%2Finvalidation%2Fresize-iframe-text.html
,
Dec 9 2016
Reland? My patch wasn't reverted.
,
Dec 9 2016
Ah, sorry, I meant re-do your patch, just for the MacOS baselines. If we land with the rebaseline bot, we risk causing the same issue again.
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42f8b3f42bfed8f61f5885e9d0c6ea02e8469c52 commit 42f8b3f42bfed8f61f5885e9d0c6ea02e8469c52 Author: mstensho <mstensho@opera.com> Date: Fri Dec 09 16:58:16 2016 Rebaseline paint/invalidation/resize-iframe-text.html for Mac. BUG= 672676 Review-Url: https://codereview.chromium.org/2557743008 Cr-Commit-Position: refs/heads/master@{#437567} [modify] https://crrev.com/42f8b3f42bfed8f61f5885e9d0c6ea02e8469c52/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/42f8b3f42bfed8f61f5885e9d0c6ea02e8469c52/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/resize-iframe-text-expected.png [modify] https://crrev.com/42f8b3f42bfed8f61f5885e9d0c6ea02e8469c52/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/resize-iframe-text-expected.txt [modify] https://crrev.com/42f8b3f42bfed8f61f5885e9d0c6ea02e8469c52/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/resize-iframe-text-expected.png [modify] https://crrev.com/42f8b3f42bfed8f61f5885e9d0c6ea02e8469c52/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/resize-iframe-text-expected.txt [modify] https://crrev.com/42f8b3f42bfed8f61f5885e9d0c6ea02e8469c52/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/resize-iframe-text-expected.png [modify] https://crrev.com/42f8b3f42bfed8f61f5885e9d0c6ea02e8469c52/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/resize-iframe-text-expected.txt
,
Dec 9 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Dec 9 2016