Autofill disabled warning below "Payment not secure" needs wording tweak |
||
Issue descriptionChrome Version: 57.0.2945.3 What steps will reproduce the problem? (1) Visit http://rsolomakhin.github.io/autofill/ (2) Select the "Simpsons" button on the "Credit Card autofill" form and submit it. (3) In the bubble choose to save the credit card information. (4) Go back to http://rsolomakhin.github.io/autofill/ and focus the "Name on card" field. What is the expected result? Second row of autofill dropdown says "Payment autofilling disabled". What happens instead? Second row of autofill dropdown says "Automatic credit card filling is disabled..."
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f871c1f29a63064081b6f65300d6a1262d4ad0d2 commit f871c1f29a63064081b6f65300d6a1262d4ad0d2 Author: estark <estark@chromium.org> Date: Thu Dec 15 21:41:46 2016 Tweak payment autofill disabled message in form-not-secure When the "Payment not secure" message is shown, the item below it should be "Payment autofilling disabled" instead of the "Automatic credit card filling is disabled..." message, and it should use the normal font rather than the warning font. This CL adds a new string and uses it for this warning message when the form-not-secure experiment is enabled. See https://bugs.chromium.org/p/chromium/issues/detail?id=672666#c2 for a screenshot. The new warning message is styled the same as the existing warning messge. To match the form-not-secure mocks, for simplicity, I've removed the warning font list and uses the normal font for the warning message, whether it is the original or new wording. BUG= 672666 Review-Url: https://codereview.chromium.org/2576143002 Cr-Commit-Position: refs/heads/master@{#438931} [modify] https://crrev.com/f871c1f29a63064081b6f65300d6a1262d4ad0d2/chrome/browser/ui/autofill/autofill_popup_layout_model.cc [modify] https://crrev.com/f871c1f29a63064081b6f65300d6a1262d4ad0d2/chrome/browser/ui/autofill/autofill_popup_layout_model.h [modify] https://crrev.com/f871c1f29a63064081b6f65300d6a1262d4ad0d2/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/f871c1f29a63064081b6f65300d6a1262d4ad0d2/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/f871c1f29a63064081b6f65300d6a1262d4ad0d2/components/autofill_strings.grdp
,
Dec 15 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by est...@chromium.org
, Dec 10 2016