New issue
Advanced search Search tips

Issue 672652 link

Starred by 1 user
Status: Fixed
Owner:
xhw...@chromium.org
Closed: Dec 2016
Cc:
xhw...@chromium.org
ddorwin@chromium.org
jrumm...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Rename CdmService to CdmRegistry

Project Member Reported by xhw...@chromium.org, Dec 9 2016 
Sorry I didn't foresee the forthcoming trend of more and more mojo "services", especially the decision of renaming "mojo app" to "mojo service".

Now CdmService and CdmServiceImpl look really like mojo services but they are not. Also we have MojoCdmService which is something different.

As pointed out by ddorwin earlier, this is not really a service, but a list or registry. Maybe it makes more sense to rename it to CdmRegistry. Thoughts?

Comment 1 by ddorwin@chromium.org, Dec 9 2016 

SGTM. For consistency and clarity, we might want to rename KeySystems[Impl] KeySystemRegistry[Impl].

Comment 2 by xhw...@chromium.org, Dec 9 2016

Owner: xhw...@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by xhw...@chromium.org, Dec 13 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ba56be620975f8da04659f7df4c91ec7d88579b

commit 5ba56be620975f8da04659f7df4c91ec7d88579b
Author: xhwang <xhwang@chromium.org>
Date: Tue Dec 13 07:13:03 2016

media: Rename CdmService to CdmRegistry

TBR=nasko@chromium.org,waffles@chromium.org
BUG= 672652 

Review-Url: https://codereview.chromium.org/2565853003
Cr-Commit-Position: refs/heads/master@{#438091}

[modify] https://crrev.com/5ba56be620975f8da04659f7df4c91ec7d88579b/chrome/browser/component_updater/widevine_cdm_component_installer.cc
[modify] https://crrev.com/5ba56be620975f8da04659f7df4c91ec7d88579b/content/browser/BUILD.gn
[modify] https://crrev.com/5ba56be620975f8da04659f7df4c91ec7d88579b/content/browser/browser_main_loop.cc
[add] https://crrev.com/5ba56be620975f8da04659f7df4c91ec7d88579b/content/browser/media/cdm_registry_impl.cc
[add] https://crrev.com/5ba56be620975f8da04659f7df4c91ec7d88579b/content/browser/media/cdm_registry_impl.h
[rename] https://crrev.com/5ba56be620975f8da04659f7df4c91ec7d88579b/content/browser/media/cdm_registry_impl_unittest.cc
[delete] https://crrev.com/3b099320199a62fcb0e8b66f50e87fd1726c2449/content/browser/media/cdm_service_impl.cc
[delete] https://crrev.com/3b099320199a62fcb0e8b66f50e87fd1726c2449/content/browser/media/cdm_service_impl.h
[modify] https://crrev.com/5ba56be620975f8da04659f7df4c91ec7d88579b/content/public/browser/BUILD.gn
[rename] https://crrev.com/5ba56be620975f8da04659f7df4c91ec7d88579b/content/public/browser/cdm_registry.h
[modify] https://crrev.com/5ba56be620975f8da04659f7df4c91ec7d88579b/content/test/BUILD.gn

Comment 5 by xhw...@chromium.org, Dec 13 2016

Status: Fixed (was: Started)
►

Sign in to add a comment